fix(cli): process group running check after EPERM on macOS#115
Merged
duguwanglong merged 1 commit intomainfrom Apr 14, 2026
Merged
fix(cli): process group running check after EPERM on macOS#115duguwanglong merged 1 commit intomainfrom
duguwanglong merged 1 commit intomainfrom
Conversation
On macOS, killpg can raise PermissionError for a defunct group leader even when no runnable members remain. Fall through to member liveness checks instead of assuming the group is still running. Made-with: Cursor
duguwanglong
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
process_group_is_runningso that whenos.killpgraisesPermissionError(e.g. macOS EPERM on a defunct group leader), we do not assume the process group is still running. We fall through to member PID checks and only return true if at least one member is alive.