fix(cli): use config backend port when stopping on start/restart#127
Merged
duguwanglong merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
…tart When runtime pid records are missing or legacy-only, start_all and restart_all now resolve the backend stop port from the current CLI ServiceConfig instead of the static default. Extract _resolve_stop_ports and _stop_all_locked for shared stop logic under the service lock. Made-with: Cursor
duguwanglong
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When stopping services before
start_all/restart_all, the backend port fallback now uses the current CLIServiceConfig(same as frontend) instead of the static default. This fixes cases where runtime pid records are missing or legacy pid-only.Changes
_resolve_stop_portsand_stop_all_lockedto centralize stop logic under the service lock.stop_allunchanged in behavior (still uses default defaults when no config).start_all/restart_allpass config so backend stop usesconfig.backend_portas fallback.Tests
Made with Cursor