Conversation
Keep the Windows packaging code changes while excluding generated installer output from version control. Update the packaging checks and scripts so release artifacts are built in CI instead of being committed.
Make Windows uninstall cleanup safer by avoiding recursive install-root deletion and only clearing browser env vars that point to the current install. Also normalize packaging PowerShell scripts to UTF-8 BOM with CRLF for Windows PowerShell 5.1 compatibility.
Resolve conflicts by keeping the PR's Windows packaging workflow and scripts.
Cache Windows packaging downloads in CI and support configurable Chrome mirror URL fallback before the default source to reduce installer build latency.
Ensure Windows packaging runs JavaScript actions on Node 24, verifies bundled uv/node/chrome versions against the manifest, and makes Finish-page launch robust by injecting install env vars without single-quote path hazards.
Prevent Inno Setup from parsing PowerShell script-block braces as constants by escaping the postinstall launch command braces in the Windows installer script.
Read bundled Chrome version from file metadata instead of executing chrome.exe in CI, and add RunOnceId for the uninstall cleanup entry to remove installer warnings.
Bump checkout/cache/upload-artifact action versions across CI and Windows packaging workflows to remove Node 20 deprecation warnings while keeping workflow behavior unchanged.
Use Start-Process with bundled venv Python as primary path and flocks.cmd as fallback so installer Finish launch no longer exits without starting services.
…uninstall
Stop launching Flocks automatically on installer finish, update the completion hint with manual startup options, and recursively delete installed code under {app} during uninstall.
Show a bilingual warning when users choose Program Files as the install directory, clarifying that running or updating Flocks may require admin privileges. Made-with: Cursor
Use the Chinese phrase expected by tests in the installer finish label while keeping the reopen-terminal guidance unchanged. Made-with: Cursor
xiami762
approved these changes
Apr 20, 2026
Bundle a newer uv release in the Windows installer so existing user uv.toml settings like python-downloads-json-url no longer break uv sync during setup. Made-with: Cursor
Use the installer-bundled Node.js toolchain when resolving npm for WebUI startup and updater rebuilds so Windows ARM64 installs avoid cross-arch rollup failures. Made-with: Cursor
xiami762
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.