Skip to content

fix(install): prefer active nvm node after installation #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duguwanglong merged 1 commit into from
Apr 20, 2026
+18 −1
Merged

fix(install): prefer active nvm node after installation #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ has_cmd() {
command -v "$1" >/dev/null 2>&1
}

clear_command_cache() {
hash -r 2>/dev/null || true
}

is_zh_install() {
[[ "$INSTALL_LANGUAGE" == zh* || "$INSTALL_LANGUAGE" == cn* ]]
}
Expand Down Expand Up @@ -92,7 +96,10 @@ run_with_privilege() {
append_path() {
local path_entry="$1"
[[ -n "$path_entry" && -d "$path_entry" ]] || return 0
[[ ":$PATH:" == *":$path_entry:"* ]] || export PATH="$path_entry:$PATH"
if [[ ":$PATH:" != *":$path_entry:"* ]]; then
export PATH="$path_entry:$PATH"
clear_command_cache
fi
}

record_path_update_file() {
Expand Down Expand Up @@ -472,6 +479,16 @@ install_nodejs_with_nvm() {
warn "Node.js ${MIN_NODE_MAJOR} was installed with nvm, but activating it failed.$(nodejs_manual_download_hint)"
return 1
fi

if [[ -n "${NVM_BIN:-}" && -d "$NVM_BIN" ]]; then
append_path "$NVM_BIN"
fi
clear_command_cache

if ! node_version_satisfies_requirement; then
warn "nvm activated Node.js ${MIN_NODE_MAJOR}, but the current shell still resolves a different node binary. Open a new shell and retry.$(nodejs_manual_download_hint)"
return 1
fi
}

install_nodejs_macos() {
Expand Down
Loading