feat(session): explicit model pinning for sessions and HTTP resolution#169
Merged
duguwanglong merged 2 commits intomainfrom Apr 23, 2026
Merged
feat(session): explicit model pinning for sessions and HTTP resolution#169duguwanglong merged 2 commits intomainfrom
duguwanglong merged 2 commits intomainfrom
Conversation
added 2 commits
April 23, 2026 13:55
- Add SessionInfo.model_pinned and helpers for pin/update/inheritance - Align _resolve_model with SessionLoop (pinned session, parent pin) - Persist pin when request.model is explicit; avoid persisting resolved defaults for unpinned sessions in SessionLoop - Propagate pinned models through inbound dispatcher for /model and /new - Add regression tests; fix PDF multimodal test to mock file_extractor Made-with: Cursor
Keep category and inherited default task models as runtime overrides instead of persisting them as pinned session state. Only explicit child model selections or inherited pinned parent models now lock child sessions, with regression tests covering task and delegate flows. Made-with: Cursor
duguwanglong
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
model_pinnedon session metadata so provider/model can be explicitly locked, aligns HTTP_resolve_modelwith SessionLoop priority (including parent pinned sessions), stops persisting resolved defaults for unpinned sessions in SessionLoop, and propagates pinned models through the inbound channel dispatcher for native commands.Testing
uv run pytest tests/agent/test_unified_session_loop.py tests/channel/test_channel.py -qMade with Cursor