feat(onesec): align tool schemas, docs, and registry startup validation#170
Merged
duguwanglong merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
added 2 commits
April 23, 2026 15:44
- Document explicit time windows and recent vs paginated EDR actions - Require registry_type for edr_delete_registry_startup; fix YAML field docs - Update grouped tool descriptions for separate API Key/Secret config - Add DNS domain_list alias; refresh ops/software common field hints - Add tests for registry startup delete validation and request payload Made-with: Cursor
- Validate and forward incident_id for threat timeline and recent timeline APIs - Clarify recent vs incidents time windows and timeline prerequisites in docs/YAML - Add EDR tests for 24h recent window, timeline validation, and JSON payloads - Add high-risk write operation tests (cases 31-40) for OneSEC threat/EDR actions Made-with: Cursor
duguwanglong
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates OneSEC grouped tools and the
onesec-useAPI reference so agents get clearer guidance on time windows, credential configuration, and field names.Changes
recentEDR actions, recommend explicittime_from/time_to, add time-window table and templates.registry_typeforedr_delete_registry_startup; alignregistry_path/registry_typedescriptions with the API payload; soften wording on optional time for paginated endpoints (server default window as fallback only).api_key|secretsingle-field wording with separate API Key and Secret configuration.domain_listas an alias for domain list parameters.Testing
uv run pytest tests/tool/test_onesec_api_tool.py -q— 18 passed.Made with Cursor