fix(cli): reuse runtime host/port on restart; harden Windows PID checks#205
Merged
duguwanglong merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
- Restart loads last recorded backend/webui host and port when CLI and env omit them; CLI and env still override runtime defaults. - On Windows, validate tracked PIDs against command line and image name so stale PID reuse does not kill unrelated processes or skip cleanup. - Add tests for restart defaults and Windows PID reuse scenarios. Made-with: Cursor
duguwanglong
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flocks restartnow loads the last recorded backend and WebUI host/port from runtime PID files when the CLI and environment omit them. Explicit CLI flags andFLOCKS_*_HOST/FLOCKS_*_PORTenv vars still win over those defaults.Tests
tests/cli/test_service_manager.py— Windows stale PID cleanup andstop_onewithout taskkill when PID is reusedtests/server/test_server_port_config.py— restart reuses runtime host/port; CLI and env overridesChecklist
Made with Cursor