Conversation
- Rename plugin dir sangfor_sip -> sangfor_sip_v92 (avoid `.` in dir name; service_id stays "sangfor_sip" so existing config & secrets continue to work unchanged). - Add `version: "9.2"` and `defaults.product_version: "9.2"` to _provider.yaml, mirroring ngsoc convention. - Fix login auth: `desc` field now sent as `auth_desc` (was empty string, breaking sha1 signature) and login URL appends `?verify=false` per 92-version spec. - Correct endpoint names to lowercase per 92-version spec: riskBusiness->riskbusiness, secEvent->riskevent, weakPassword->weakpasswd, vulInfo->hole, plainTextInfo->plaintexttransmission. - Add risk_terminal action (/data/riskterminal) and expose it via sangfor_sip_risk.yaml `action` parameter. - Cap maxCount in _fetch_data: 10000 normal / 5000 vulnerability; align assets.yaml default & description accordingly. - Fix terminal classfy1_id description: 2 -> 2,7,8.
duguwanglong
force-pushed
the
fix/sangfor-sip-endpoints
branch
from
8eab428 to
f4e9723
Compare
- Add `_resolve_verify_ssl` helper that reads `verify_ssl` / `ssl_verify` / `custom_settings.verify_ssl` (matches the onesec/qingteng/ngtip pattern from PR #193). The bottom "SSL 验证" form toggle writes to `custom_settings.verify_ssl`, which the handler previously ignored — causing the toggle to have no effect at runtime. - Drop the standalone `verify_ssl` credential_field from _provider.yaml so the WebUI no longer renders a duplicate text input next to the bottom SSL toggle. - Refresh _provider.yaml notes to describe the new SSL toggle resolution precedence.
xiami762
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sangfor_sip): align with v9.2 spec and rename plugin dir to v92
.in dirname; service_id stays "sangfor_sip" so existing config & secrets
continue to work unchanged).
version: "9.2"anddefaults.product_version: "9.2"to_provider.yaml, mirroring ngsoc convention.
descfield now sent as auth_desc (was emptystring, breaking sha1 signature) and login URL appends
?verify=falseper 92-version spec.riskBusiness→riskbusiness, secEvent→riskevent,
weakPassword→weakpasswd, vulInfo→hole,
plainTextInfo→plaintexttransmission.
sangfor_sip_risk.yaml
actionparameter.align assets.yaml default & description accordingly.