feat(updater): Windows webui npm fallback and Session ownerUsername#253
Merged
duguwanglong merged 2 commits intoMay 11, 2026
Merged
Conversation
- Retry frontend install/build with system npm when bundled npm fails or times out - Add ownerUsername to webui Session type - Extend updater tests for Windows npm retry paths Co-authored-by: Cursor <cursoragent@cursor.com>
- Remove node_modules and dist before switching npm candidate - Avoid duplicate system npm candidate on non-Windows when bundled exists - Extend tests for workspace cleanup and Linux candidate list Co-authored-by: Cursor <cursoragent@cursor.com>
duguwanglong
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm install/ciandrun buildwith systemnpm.cmdwhen bundled Node npm fails or hits timeout, with appropriate timeouts and env.ownerUsernameonSessionin TypeScript types.