fix(install): pin nvm toolchain when PATH resolves stale Node#274
Merged
Conversation
When nvm activates a supported Node version but `node` on PATH remains older, pin NODE_CMD/NPM_CMD/NPX_CMD to NVM_BIN for the rest of the installer run. Adds a Linux integration test for the stale-resolution scenario. Co-authored-by: Cursor <cursoragent@cursor.com>
duguwanglong
approved these changes
May 15, 2026
duguwanglong
pushed a commit
to DearEmma/flocks
that referenced
this pull request
May 18, 2026
…gentFlocks#274) When nvm activates a supported Node version but `node` on PATH remains older, pin NODE_CMD/NPM_CMD/NPX_CMD to NVM_BIN for the rest of the installer run. Adds a Linux integration test for the stale-resolution scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_CMD/NPM_CMD/NPX_CMDhelpers so the bash installer can call a pinned Node toolchain instead of whatevernode/npm/npxhappen to resolve onPATH.nodebutNVM_BINis usable, continue the install using the nvm-managed binaries and warn the user to open a new shell.PATHscenario.Test plan
uv run pytest tests/scripts/test_install_script_sources.py tests/scripts/test_browser_runtime_configuration.pyMade with Cursor