fix(feishu): stabilize legacy WebSocket client loop lifecycle#288
Merged
Conversation
Defer lark_oapi Client construction to the background thread's event loop to avoid "attached to a different loop" errors. Track ping/receive tasks and reset state on stop so restart is reliable. Co-authored-by: Cursor <cursoragent@cursor.com>
Wait for worker-thread client init before stop proceeds; skip start when stop is requested early. Guard coroutine scheduling when loop is not running. Co-authored-by: Cursor <cursoragent@cursor.com>
duguwanglong
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lark_oapiWebSocket client on the worker thread's event loop to avoid "attached to a different loop" errors.stop()during slow client initialization: wait for init, skipstart()when stop is requested, and avoid scheduling on a stopped loop.