fix/delegate button disabled during subagent#99
Merged
Conversation
The previous fix used reference equality (===) to compare state.metadata, which is unreliable: SSE events produce a new object on every JSON.parse, causing unnecessary re-renders when metadata has not actually changed; conversely, an in-place mutation would be silently missed. Switch to JSON.stringify for a stable content-based comparison. For the common case where metadata is undefined, JSON.stringify returns undefined on both sides with zero extra cost. For DelegateTaskCard parts the payload is small (sessionId, steps, stepCount, currentText, elapsed), so the serialisation overhead is negligible. Made-with: Cursor
…e-button-disabled-during-subagent
xiami762
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(webui): use deep comparison for metadata in ChatMessageBubble memo
The previous fix used reference equality (===) to compare state.metadata,
which is unreliable: SSE events produce a new object on every JSON.parse,
causing unnecessary re-renders when metadata has not actually changed;
conversely, an in-place mutation would be silently missed.
Switch to JSON.stringify for a stable content-based comparison. For the
common case where metadata is undefined, JSON.stringify returns undefined
on both sides with zero extra cost. For DelegateTaskCard parts the
payload is small (sessionId, steps, stepCount, currentText, elapsed), so
the serialisation overhead is negligible.