Skip to content

refactor files#72

Merged
chinganc merged 4 commits into
experimentalfrom
trainer_refactoring
May 26, 2026
Merged

refactor files#72
chinganc merged 4 commits into
experimentalfrom
trainer_refactoring

Conversation

@xuanfeiren
Copy link
Copy Markdown
Collaborator

Move the PS search family from features to the main code and retire the other trainer implementation as examples.

@xuanfeiren xuanfeiren requested a review from chinganc April 16, 2026 04:44
@chinganc
Copy link
Copy Markdown
Member

@xuanfeiren Thanks for initiating this. Here're some changes needed still. Thanks.

  • Move things opto/trainer/supporting_files back to opto/trainer/ except for the following.
  • Move opto/trainer/supporting_files/examples.py' opto/trainer/algorithms/classical_algorithms.py`
  • Where is `opto/trainer/supporting_files/module_regressor.py' used? if not, remove it.
  • Move opto/trainer/examples to examples/trainers and remove aggregator.py there, as we discussed.

@chinganc
Copy link
Copy Markdown
Member

LGTM. @allenanie Can you run some tests on the trace bench with this PR? to make nothing is broken there. If not, I think it's ready to be merged.

@chinganc chinganc self-assigned this Apr 28, 2026
@chinganc chinganc requested a review from allenanie April 28, 2026 21:39
@chinganc
Copy link
Copy Markdown
Member

Integration with trace bench was tested. It is found PS misses the mechanism of selecting the best candidates via validation. Fix to PS will be implemented in future PR @xuanfeiren @allenanie .

@chinganc chinganc merged commit acb9719 into experimental May 26, 2026
1 check passed
@chinganc chinganc deleted the trainer_refactoring branch May 26, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants