fix: dedupe conflict findings by document pair - #15
Closed
slegarraga wants to merge 2 commits into
Closed
Conversation
|
Welcome, @slegarraga, and thanks for your first pull request to VaultRAG. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
Collaborator
|
Closing this PR. The author is no longer an active contributor on these repositories, so this cannot be carried through review or iterated on. The underlying issue stays open and is available for anyone who wants it. If you were looking at this change, please do open a fresh PR, it is very welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
Deduplicates conflict findings by unordered document pair so multiple chunks from the same documents produce one conflict, not one per chunk pair. Applies the dedupe to both the official-official and official-informal loops.
Adds regression tests for both duplicate-chunk shapes.
Verified with
pytest tests/test_conflicts.py -k conflict(12 passed; the remaining async DB tests require a local Postgres and were not runnable here).