Skip to content

Revert "feat(claude-plugin): record guideline usage per session in audit.log"#248

Merged
illeatmyhat merged 1 commit into
mainfrom
revert-239-provenance-usage
May 4, 2026
Merged

Revert "feat(claude-plugin): record guideline usage per session in audit.log"#248
illeatmyhat merged 1 commit into
mainfrom
revert-239-provenance-usage

Conversation

@visahak
Copy link
Copy Markdown
Collaborator

@visahak visahak commented May 4, 2026

Reverts #239

Summary by CodeRabbit

  • Refactor

    • Simplified the recall workflow by removing the entity influence assessment step, streamlining the overall process.
    • Removed influence tracking and event logging from the audit trail.
  • Tests

    • Updated end-to-end tests to reflect workflow changes and removed related test suite for the discontinued feature.

@visahak visahak requested a review from illeatmyhat May 4, 2026 19:39
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 739e777a-83ac-4f55-b707-1e1c32d7c487

📥 Commits

Reviewing files that changed from the base of the PR and between a2ab28c and 75c9255.

📒 Files selected for processing (5)
  • platform-integrations/claude/plugins/evolve-lite/skills/learn/SKILL.md
  • platform-integrations/claude/plugins/evolve-lite/skills/learn/scripts/log_influence.py
  • platform-integrations/claude/plugins/evolve-lite/skills/recall/scripts/retrieve_entities.py
  • tests/e2e/test_sandbox_learn_recall.py
  • tests/platform_integrations/test_log_influence.py
💤 Files with no reviewable changes (4)
  • platform-integrations/claude/plugins/evolve-lite/skills/learn/scripts/log_influence.py
  • platform-integrations/claude/plugins/evolve-lite/skills/learn/SKILL.md
  • tests/e2e/test_sandbox_learn_recall.py
  • tests/platform_integrations/test_log_influence.py

📝 Walkthrough

Walkthrough

This PR removes the entire influence-assessment workflow from the evolve-lite plugin. The "Step 5: Assess Influence" documentation is deleted, the log_influence.py script is removed, audit hooks in retrieve_entities.py are stripped, and all related test coverage is eliminated. The learn and recall skills now skip entity-influence tracking.

Changes

Influence Assessment Removal

Layer / File(s) Summary
Workflow Documentation
platform-integrations/claude/plugins/evolve-lite/skills/learn/SKILL.md
Step 5 ("Assess Influence of Recalled Entities") is deleted; the workflow now transitions directly from Step 4 (Save Entities) to the Quality Gate.
Core Script Removal
platform-integrations/claude/plugins/evolve-lite/skills/learn/scripts/log_influence.py
The entire log_influence.py script is deleted, removing JSON validation, per-entity verdict computation, and audit-log append logic.
Audit Hook Removal
platform-integrations/claude/plugins/evolve-lite/skills/recall/scripts/retrieve_entities.py
Imports of get_evolve_dir and audit are removed, entity _id assignment is deleted, and the audit event logging in main() is stripped.
Test Coverage Removal
tests/platform_integrations/test_log_influence.py
Entire test file deleted, removing subprocess helper and TestLogInfluence integration test suite (199 lines).
E2E Test Updates
tests/e2e/test_sandbox_learn_recall.py
Post-recall audit assertions for recall and influence events are removed; only the exiftool ban check remains.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • AgentToolkit/altk-evolve#239: Directly reverts the recall/influence logging changes; modifies the same files (SKILL.md, log_influence.py, retrieve_entities.py, and tests).

Suggested reviewers

  • illeatmyhat
  • vinodmut

🐰 The influence fades, the logs grow quiet,
Step 5 removed—a workflow diet.
No verdicts now, no audit trail,
Just save and gate; influence set sail.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the pull request as a revert of a previous feature commit, and the raw summary confirms this is removing the guideline usage tracking infrastructure (log_influence.py, audit logging, and related test coverage).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-239-provenance-usage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@visahak visahak requested a review from vinodmut May 4, 2026 19:39
@illeatmyhat illeatmyhat merged commit 3996a2e into main May 4, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants