publish.yml: locate staged CLI binary with find (fixes 2.0 publish run)#363
publish.yml: locate staged CLI binary with find (fixes 2.0 publish run)#363willwashburn merged 1 commit intomainfrom
Conversation
The CodeRabbit-suggested fix in #362 ("upload-artifact@v4 preserves directory structure for single-file uploads") was based on outdated docs. Empirical run https://github.com/AgentWorkforce/burn/actions/runs/25503503514 showed the binary actually lands at the artifact root (/tmp/cli-artifacts/relayburn-cli-<short>/burn), not at the nested packages/relayburn/npm/<short>/bin/burn path. The first publish run hit the nested-path "if [ ! -f ]" guard and exited before staging. Defensive: locate the binary with 'find -name burn -type f' rather than hard-coding either layout, mirroring the SDK leg's pattern for *.node. A future upload-artifact behavior change won't silently break staging.
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe publish workflow's "Stage prebuilt binaries into platform packages" step is updated to discover the ChangesCLI Artifact Staging in Publish Workflow
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What
The 2.0 cutover publish run failed at the Stage prebuilt binaries into platform packages step: https://github.com/AgentWorkforce/burn/actions/runs/25503503514/job/74844319389
The hard-coded
cli_srcpath expectedupload-artifact@v4to preserve the full directory hierarchy for single-file uploads (per a CodeRabbit web-search suggestion in #362 review). Empirically, it doesn't — the binary lands at the artifact root:Fix
Locate the binary with
findrather than hard-coding either layout, mirroring the SDK leg's pattern for*.node. Survives future upload-artifact behavior changes.State of the cutover release
The previous run did successfully:
3c1c080✓relayburn-sdk@2.0.0andrelayburn-cli@2.0.0to crates.io ✓It failed AFTER cargo publish but BEFORE npm publish, so:
After this PR merges, re-trigger the workflow with
version: noneto skip the bump (already done) and re-run cargo publish (idempotent — version check skips if already published) and proceed to npm publish.