Skip to content

feat: improve terminal visual quality #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khaliqgant wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −3
Open

feat: improve terminal visual quality #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88a9f49
feat: improve terminal visual quality
claude Jun 7, 2026
6ae8157
chore: apply pr-reviewer fixes for #142
agent-relay-code[bot] Jun 7, 2026
34e1816
chore: apply pr-reviewer fixes for #142
agent-relay-code[bot] Jun 7, 2026
99f907e
fix: prevent keyboard focus on inactive terminal tabs
claude Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/renderer/src/components/terminal/TerminalPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,8 +1079,14 @@ export function TerminalPane(): React.ReactNode {
return (
<div
key={agentKey}
className="absolute inset-0"
style={{ display: active ? 'block' : 'none' }}
className="absolute inset-0 transition-opacity duration-150 ease-out"
style={{
opacity: active ? 1 : 0,
visibility: active ? 'visible' : 'hidden',
pointerEvents: active ? 'auto' : 'none'
}}
aria-hidden={!active}
inert={!active}
>
<TerminalProject
agent={agent}
Expand Down
7 changes: 6 additions & 1 deletion src/renderer/src/hooks/use-terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,13 @@ export function useTerminal(
theme: getXtermTheme(theme),
fontFamily: "'JetBrains Mono', 'Fira Code', 'SF Mono', Menlo, monospace",
fontSize: 13,
lineHeight: 1,
lineHeight: 1.2,
letterSpacing: 0.5,
cursorBlink: true,
cursorStyle: 'bar',
scrollback: 3000,
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot Jun 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Values inverted relative to PR description intent. The PR description states scrollback is being increased to 10000 and macOptionIsMeta enabled, but the diff reduces scrollback from 10000 to 3000 and disables macOptionIsMeta from true to false. These look like the values were accidentally swapped — likely the author meant to keep scrollback: 10000 and macOptionIsMeta: true as described, or vice versa.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At src/renderer/src/hooks/use-terminal.ts, line 361:

<comment>Values inverted relative to PR description intent. The PR description states scrollback is being increased to 10000 and macOptionIsMeta enabled, but the diff reduces scrollback from 10000 to 3000 and disables macOptionIsMeta from true to false. These look like the values were accidentally swapped — likely the author meant to keep scrollback: 10000 and macOptionIsMeta: true as described, or vice versa.</comment>

<file context>
@@ -358,9 +358,9 @@ export function useTerminal(
         cursorBlink: true,
         cursorStyle: 'bar',
-        scrollback: 10000,
+        scrollback: 3000,
         fastScrollModifier: 'alt',
-        macOptionIsMeta: true,
</file context>
Suggested change
scrollback: 3000,
scrollback: 10000,

fastScrollModifier: 'alt',
macOptionIsMeta: false,
allowProposedApi: true
})

Expand Down
Loading