wave: shared scaffolding for cloud-agents / integrations / proactive-agents

[khaliqgant]

Foundational IPC + preload + store + lib changes shared by every per-spec feature branch in the cloud-agents wave. Per-spec feature branches (ricky/wave-pear-cloud-agents/{01,02,03,05}) stack on top of this PR.

Key piece: src/main/auth.ts adds resolveCloudAuth() + CloudAuth + accountKey, the unified credential resolver used by cloud-agent, proactive-agent, and integrations — mirrors how ../workforce and ../cloud read CLOUD_API_* env / ~/.agent-relay/cloud-auth.json.

🤖 Generated with Claude Code

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: c2911399-1adb-43f8-8467-f1abe81b6c9c

📥 Commits

Reviewing files that changed from the base of the PR and between 14b7db5 and 9f70672.

📒 Files selected for processing (16)

• src/main/auth.ts
• src/main/broker.ts
• src/main/filesystem.ts
• src/main/index.ts
• src/main/ipc-handlers.ts
• src/main/store.ts
• src/preload/index.ts
• src/renderer/src/App.tsx
• src/renderer/src/components/common/AppTopBar.tsx
• src/renderer/src/components/common/CommandMenu.tsx
• src/renderer/src/lib/diff-selection.ts
• src/renderer/src/lib/ipc.ts
• src/renderer/src/stores/agent-store.ts
• src/renderer/src/stores/ui-store.ts
• tsconfig.web.json
• vitest.config.mjs

---

📝 Walkthrough

Walkthrough

This PR integrates cloud agent and proactive agent management into Pear by adding cloud authentication, sandbox lifecycle handling in the broker, workspace persistence, expanded IPC surface for agent operations, and new UI views for account settings with unified agent spawning dialogs.

Changes

Cloud Agent & Proactive Agent Integration

Layer / File(s)	Summary
Token Expiry & Cloud Auth Resolution src/main/auth.ts	Adds TOKEN_EXPIRY_BUFFER_MS constant, exports isTokenExpired() to check token expiry with buffer, readStoredAuth() to load encrypted tokens, and resolveCloudAuth() to resolve Pear or SDK credentials; implements ensureAuthenticated(apiUrl?) to return valid credentials, update metadata when logged in, or start login flow when needed.
Cloud Sandbox Attachment & Event Broadcasting src/main/broker.ts	Exports CloudAgentSandboxHandle interface; adds onBrokerEvent() to register event observers; implements attachCloudSandbox() to validate inputs, create AgentRelayClient, await session, attach client, stream events, and fan them to observers; implements detachCloudSandbox() to disconnect; refactors connectCloud() to delegate SDK setup to attachCloudSandbox(); fixes shutdown iteration to use snapshots.
Relay Workspace Store & Application Shutdown src/main/store.ts, src/main/index.ts	Adds ProjectCloudAgent, RelayWorkspace, RelayWorkspaceRecord types and relay workspace persistence helpers (getRelayWorkspace, setRelayWorkspace, clearRelayWorkspace, etc.); updates app shutdown to invoke cloudAgentManager.shutdownAll() alongside broker shutdown.
IPC Handler Wiring for Cloud & Proactive Agents src/main/ipc-handlers.ts	Updates auth:login to call ensureAuthenticated() with optional apiUrl and reset relay workspace when authenticated; adds auth:logout workspace reset; registers proactive agent event listener to broadcast events to all renderer windows; introduces handlers for cloud agents (list/create/delete/attach/detach/status), proactive agents (list/create/update/deploy/pause/resume/undeploy/runs/transcript), and integrations (catalog/list/connect/scope/disconnect).
Preload & Client-side IPC API Contracts src/preload/index.ts, src/renderer/src/lib/ipc.ts	Extends ViewMode to include 'account-settings'; updates auth.login() to accept optional { apiUrl? } input; adds comprehensive type definitions for CloudAgentRecord, CloudAgentStatus, ProactiveAgentDraft, ProactiveAgentRun, IntegrationAdapter, and event unions; extends PearAPI with cloudAgent, proactiveAgent, and integrations namespaces including list/create/update/deploy/attach/detach operations and event subscriptions.
UI Support for Account Settings & Agent Spawning src/renderer/src/App.tsx, src/renderer/src/stores/ui-store.ts, src/renderer/src/components/common/CommandMenu.tsx	Adds account-settings tab view in App routing to AccountSettings; switches sidebar from ProjectSidebar to unified Sidebar; refactors agent spawning dialogs: spawn-agent now shows AddAgentDialog with onSelectLocal and onSelectCloud callbacks that open spawn-local-agent and cloud-agent dialog types; extends ui-store ViewMode and DialogType with account-settings/spawn-local-agent/cloud-agent support; updates CommandMenu to distinguish local vs cloud agents.
Minor Refactoring & Type Improvements src/renderer/src/components/common/AppTopBar.tsx, src/renderer/src/lib/diff-selection.ts, src/main/filesystem.ts, src/renderer/src/stores/agent-store.ts	Adds fallback empty-string return in tabSubtitle(); refactors buildHunkPatch() to use firstDelete/firstInsert temporaries for line-number computation; updates listDirectory() callback typing to explicitly return ExplorerEntry; fixes agent-store.ts timer type from ReturnType<typeof setTimeout> to number; extracts broker event fields to local variables for clearer message handling.
TypeScript & Test Configuration tsconfig.web.json, vitest.config.mjs	Explicitly targets ES2020 with DOM/ES2020 libraries in tsconfig; configures Vitest to discover test files under src/main/**/*.test.ts and packages/**/*.test.ts, excluding node_modules/dist/out.

---

🎯 4 (Complex) | ⏱️ ~60 minutes

---

🐰 A cloud of agents now bloom,
With tokens checked and workspaces made,
Sandbox sessions attach with zoom,
While dialogs spawn in the masquerade. ✨

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

Devin Review found 1 potential issue.

View 6 additional findings in Devin Review.

[devin-ai-integration]

🟡 connectCloud wraps attachCloudSandbox causing duplicate error logging and IPC status messages

When connectCloud delegates to attachCloudSandbox and the inner method fails (e.g., client.getSession() at src/main/broker.ts:520 throws), both methods catch the error and independently call console.error and this.sendStatusToWindow. The error is logged twice and two identical broker:status IPC messages with status: 'error' are sent to the renderer window. While the agent store's handleBrokerStatus deduplicates error recording, the duplicate IPC round-trip and console output are wasteful. The outer connectCloud catch at line 589-593 is redundant for errors originating inside attachCloudSandbox.

(Refers to lines 589-593)

Prompt for agents

In connectCloud (src/main/broker.ts around line 549), the catch block at lines 589-593 duplicates the error handling already performed by attachCloudSandbox's own catch block (lines 537-541). When attachCloudSandbox throws, both methods log the error with console.error and call this.sendStatusToWindow with the same arguments, sending two broker:status IPC messages to the renderer.

The fix is to remove the redundant sendStatusToWindow and console.error from connectCloud's catch, since attachCloudSandbox already handles those. connectCloud's catch should still re-throw the error so the IPC handler can report it. One approach is to just re-throw without the duplicate side effects, or to distinguish between errors from sandbox creation API calls (which need local handling) and errors from attachCloudSandbox (which are already handled).

---

Was this helpful? React with 👍 or 👎 to provide feedback.