fix: comprehensive mobile touch scrolling for log viewer#154
Merged
khaliqgant merged 1 commit intomainfrom Jan 11, 2026
Merged
Conversation
Previous fix (#153) added touch-action to xterm-viewport and xterm-screen, but mobile scrolling still didn't work reliably because: 1. xterm.js has multiple elements that intercept touch events (canvas, helper-textarea, rows div) - all now have touch-action: pan-y 2. The container div had overflow-auto, creating nested scrollable containers which confuses mobile touch handling - removed this since xterm-viewport handles its own scrolling 3. Added !important to CSS rules to ensure they override any inline styles xterm.js might apply Also added overscroll-behavior: contain to inline LogViewer mode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 My Senior Dev — Analysis Complete👤 For @khaliqgant📁 Expert in View your contributor analytics → 📊 2 files reviewed • 1 need attention
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mobile touch scrolling in the log viewer that PR #153 attempted to fix but didn't fully resolve.
Root Cause Analysis
The previous fix (#153) only partially addressed the issue:
overflow-auto, creating TWO scrollable containers (the container AND xterm-viewport). This confuses mobile touch handling because the browser doesn't know which container should scroll!important, xterm.js inline styles could override our touch-action rulesChanges
XTermLogViewer.tsx
touch-action: pan-yto ALL xterm elements:.xterm,.xterm-viewport,.xterm-screen,canvas,.xterm-helper-textarea,.xterm-rows!importantto ensure rules override xterm's inline stylesoverflow-autofrom container div - let xterm-viewport be the sole scrollable elementLogViewer.tsx (inline mode)
overscrollBehavior: 'contain'to prevent iOS page bounceTest plan
🤖 Generated with Claude Code