Fix trajectory viewer loading wrong data due to race condition#163
Merged
khaliqgant merged 1 commit intomainfrom Jan 12, 2026
Merged
Fix trajectory viewer loading wrong data due to race condition#163khaliqgant merged 1 commit intomainfrom
khaliqgant merged 1 commit intomainfrom
Conversation
Added latestSelectionRef to track the most current trajectory selection and prevent stale fetches from overwriting newer data. Root cause: When the user quickly clicked a trajectory after opening the panel, the initial fetch (with null ID) could complete after the selected trajectory's fetch, overwriting the correct data with stale results. Fix: - Added latestSelectionRef to track current selection - selectTrajectory updates the ref immediately (synchronously) - fetchSteps checks if fetched ID matches current selection before updating state - Stale fetches are now logged and discarded 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 My Senior Dev — Analysis Complete👤 For @khaliqgant📁 Expert in View your contributor analytics → 📊 1 file reviewed • 3 need attention
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latestSelectionRefto track current selection and ignore stale fetchesTechnical Details
When the user opened the trajectory panel and quickly clicked a trajectory:
The fix:
latestSelectionReftracks the most recent trajectory selectionselectTrajectory()updates the ref immediately (synchronously, before state update)fetchSteps()checks if the fetched ID matcheslatestSelectionRef.currentbefore updating stateTest plan
🤖 Generated with Claude Code