Skip to content

Fix trajectory viewer showing wrong data by using unique step IDs #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 1 commit into from
Jan 12, 2026
Merged

Fix trajectory viewer showing wrong data by using unique step IDs #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/trajectory/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,10 +582,13 @@ export async function listTrajectorySteps(trajectoryId?: string): Promise<{
}
Copy link
Copy Markdown
Member Author

@khaliqgant khaliqgant Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Conversation Transcript

👤 khaliqgant

so how was this loading in a trajectory at all?

🤖 AI Assistant

The code in question is part of a function that likely retrieves and processes steps from a trajectory, which is a series of events or actions taken in a certain context (like a simulation, animation, or user actions).

Here's how it relates to loading a trajectory:

  1. Trajectory Identification: The trajectory is identified by an ID, which is retrieved using const trajId = trajectory.id || 'unknown';. This line attempts to get the id of the trajectory being processed. If the ID is not available, it defaults to 'unknown'.

  2. Event Processing: The nested loops iterate over trajectory.chapters and their respective events. For each event, a step is created and pushed into the steps array. This is where the line in question comes into play:

    id: `${trajId}-step-${stepIndex++}`,

    Here, the step ID is constructed using the trajectory ID and the current step index. This helps in ensuring that each step has a unique identifier, which is crucial for rendering in frameworks like React.

  3. Output: The function likely returns the constructed steps array, which contains all the processed steps of the trajectory, each identified uniquely based on the trajectory ID and step index.

If the trajectory ID is invalid or missing, the function defaults to using 'unknown', which could lead to non-unique step IDs if multiple trajectories are processed without valid IDs. This is a potential issue that could affect how the trajectory is displayed or interacted with, as outlined in the AI analysis summary.

From My Senior Dev


// Extract events from all chapters
// Include trajectory ID in step IDs to ensure uniqueness across trajectories
// This prevents React key collisions when switching between trajectories
const trajId = trajectory.id || 'unknown';
for (const chapter of trajectory.chapters || []) {
for (const event of chapter.events || []) {
steps.push({
id: `step-${stepIndex++}`,
id: `${trajId}-step-${stepIndex++}`,
timestamp: event.ts || Date.now(),
type: mapEventType(event.type),
title: event.content?.slice(0, 50) || event.type || 'Event',
Expand Down
Loading