Fix Gemini API key input opening OAuth modal on focus#167
Merged
khaliqgant merged 1 commit intomainfrom Jan 12, 2026
Merged
Conversation
When the user clicked "Or enter API key manually" for a provider like Gemini and then focused the API key input field, the OAuth popup would open unexpectedly. Root cause: The input's onFocus handler set `connectingProvider` to the provider ID. The render condition `connectingProvider === provider.id` was checked BEFORE `showApiKeyFallback[provider.id]`, so it would render ProviderAuthFlow (which auto-starts OAuth on mount) instead of the API key input. Fix: Add `&& !showApiKeyFallback[provider.id]` to the condition, so that when the user is in API key fallback mode, it doesn't render the OAuth flow even if connectingProvider is set. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 My Senior Dev — Analysis Complete👤 For @khaliqgant📁 Expert in View your contributor analytics → 📊 1 file reviewed • 4 need attention
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
In
WorkspaceSettingsPanel.tsx, the render logic checked conditions in this order:connectingProvider === provider.id→ shows ProviderAuthFlow (OAuth)showApiKeyFallback[provider.id]→ shows API key inputWhen the user focused the API key input,
onFocussetconnectingProviderto the provider ID. This made condition 1 true, causingProviderAuthFlowto render. SinceProviderAuthFlowauto-starts OAuth on mount, the popup would open.Fix
Changed the condition from:
to:
Now, when the user is in API key fallback mode, the OAuth flow won't render even if
connectingProvideris set.Test plan
🤖 Generated with Claude Code