fix: version parsing in install.sh extracts wrong value#359
Merged
khaliqgant merged 8 commits intomainfrom Feb 2, 2026
Merged
Conversation
The sed pattern was too greedy, matching "mentions_count" instead of the tag_name value when the GitHub API response was on a single line. Fixed by using a more specific sed pattern that anchors to "tag_name". Added install.test.sh with 9 tests including a regression test for the mentions_count bug. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Track install_started, install_completed, and install_failed events to understand installation success rates and common failure modes. Telemetry respects: - AGENT_RELAY_TELEMETRY_DISABLED=1 - DO_NOT_TRACK=1 Also: - Added install.test.sh to CI workflow - Updated help text with telemetry opt-out info 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fedora doesn't include 'which' by default. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
The install script puts binaries in ~/.local/bin which isn't in PATH by default. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Disable set -e during live API test to prevent script exit on curl failures (rate limiting, network issues). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1. Escape special characters (newlines, quotes, backslashes) in error messages before embedding in telemetry JSON 2. Add '|| true' to arithmetic expressions to prevent exit code 1 when incrementing from 0 with set -e enabled 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sed pattern was too greedy, matching "mentions_count" instead of the tag_name value when the GitHub API response was on a single line.
Fixed by using a more specific sed pattern that anchors to "tag_name".
Added install.test.sh with 9 tests including a regression test for the mentions_count bug.