Skip to content

Handle undefined bridge config content in tests#459

Merged
willwashburn merged 1 commit into
mainfrom
fix-publish-workflow-matrix-sdk-repository
Feb 27, 2026
Merged

Handle undefined bridge config content in tests#459
willwashburn merged 1 commit into
mainfrom
fix-publish-workflow-matrix-sdk-repository

Conversation

@willwashburn
Copy link
Copy Markdown
Member

@willwashburn willwashburn commented Feb 27, 2026

Summary

  • make skip non-string and empty file content before JSON parsing
  • prevent noisy parse errors when mocked fs returns undefined in tests
  • add a regression test to ensure non-string bridge config content is ignored without logging parse errors

Validation

  • ran

@agent-relay/config@2.3.14 test
vitest run

RUN v3.2.4 /Users/will/Projects/relay/packages/config

✓ src/relay-config.test.ts (4 tests) 2ms
✓ src/bridge-config.test.ts (11 tests) 5ms
✓ src/agent-config.test.ts (16 tests) 16ms
✓ src/schemas.test.ts (7 tests) 3ms
✓ src/relay-file-writer.test.ts (27 tests) 32ms

Test Files 5 passed (5)
Tests 65 passed (65)
Start at 08:58:29
Duration 299ms (transform 172ms, setup 0ms, collect 287ms, tests 58ms, environment 0ms, prepare 294ms)

  • all tests pass (65/65)

@willwashburn willwashburn merged commit c5cf969 into main Feb 27, 2026
31 of 32 checks passed
@willwashburn willwashburn deleted the fix-publish-workflow-matrix-sdk-repository branch February 27, 2026 03:49
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@willwashburn willwashburn changed the title Refresh PR head Handle undefined bridge config content in tests Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant