fix: SDK publish includes freshly built broker binary

[khaliqgant]

Summary

• publish-sdk-only job was shipping a stale broker binary — it only depended on the TS build job and used --ignore-scripts (skipping prepack → bundle:binary), so it published whatever old binary was checked into packages/sdk/bin/ instead of the freshly compiled one from build-broker
• Fix: Added build-broker to needs, download CI-built broker artifacts into packages/sdk/bin/, and make them executable before npm publish
• Removed 13MB broker binary from git tracking — CI builds it fresh every publish, and local dev resolves to target/release/ via resolveDefaultBinaryPath() in client.ts
• Fixed stale .gitignore — updated from packages/broker-sdk/bin/ (old package name) to packages/sdk/bin/agent-relay-broker*, kept packages/broker-sdk/ for the leftover local directory
• Fixed version commit staging — separated required paths from optional ones so git add doesn't fail when optional paths are missing

Test plan

• Trigger a dry-run SDK publish (package: sdk, dry_run: true) and verify the tarball includes broker binaries in bin/
• Verify local dev still resolves broker from target/release/ after removing the checked-in binary
• Confirm git status no longer shows packages/sdk/bin/agent-relay-broker as tracked

🤖 Generated with Claude Code

[devin-ai-integration]

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

[devin-ai-integration]

🔴 publish-sdk-only job will always be skipped because build-broker is skipped when package == 'sdk'

The publish-sdk-only job now depends on build-broker (line 487: needs: [build, build-broker]), but build-broker only runs when package == 'all' || package == 'main' (line 76). Since publish-sdk-only only runs when package == 'sdk' (line 489), the build-broker job will always be skipped in that scenario.

Root Cause: GitHub Actions skips dependent jobs when required jobs are skipped

In GitHub Actions, when a job listed in needs is skipped (due to its if condition evaluating to false), the dependent job is also skipped by default — unless the dependent job has an explicit if condition that uses always() or checks needs.*.result.

Here, publish-sdk-only at .github/workflows/publish.yml:487 has:

needs: [build, build-broker]
if: github.event.inputs.package == 'sdk'

But build-broker at .github/workflows/publish.yml:76 has:

if: github.event.inputs.package == 'all' || github.event.inputs.package == 'main'

When package == 'sdk', build-broker is skipped → publish-sdk-only is also skipped. The SDK can never be published standalone. This completely defeats the purpose of this PR.

Impact: Selecting package: sdk in the workflow dispatch will silently skip the publish job — the exact class of bug this PR claims to fix.

Prompt for agents

In .github/workflows/publish.yml, the build-broker job (line 76) has an if condition that only allows it to run when package is 'all' or 'main'. But publish-sdk-only (line 487) depends on build-broker and only runs when package is 'sdk'. This means build-broker is always skipped when publish-sdk-only should run, causing publish-sdk-only to also be skipped.

Two possible fixes:

1. Update the build-broker job's if condition at line 76 to also include 'sdk':
   if: github.event.inputs.package == 'all' || github.event.inputs.package == 'main' || github.event.inputs.package == 'sdk'

2. Alternatively, update the publish-sdk-only if condition at line 489 to handle the skipped dependency:
   if: github.event.inputs.package == 'sdk' && !cancelled()
   But this would mean broker binaries are not available, so option 1 is the correct fix.

---

Was this helpful? React with 👍 or 👎 to provide feedback.