-
Notifications
You must be signed in to change notification settings - Fork 44
more deterministic tests #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "id": "traj_c8y3gakjeuv8", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Fix publish workflow musl.cc timeout for aarch64 broker build" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-03-04T21:18:27.095Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-03-04T21:18:54.262Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_q0j0s48w0c3e", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-03-04T21:18:54.262Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1772659134263, | ||
| "type": "decision", | ||
| "content": "Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs: Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs", | ||
| "raw": { | ||
| "question": "Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs", | ||
| "chosen": "Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs", | ||
| "alternatives": [], | ||
| "reasoning": "musl.cc timeouts cause recurring CI failures; cross uses maintained target container and avoids direct dependency on musl.cc" | ||
| }, | ||
| "significance": "high" | ||
| } | ||
| ], | ||
| "endedAt": "2026-03-04T21:18:54.432Z" | ||
| } | ||
| ], | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/Users/khaliqgant/Projects/agent-workforce/relay", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "30d6ae6ba1230c5ab41937a5e05e8c3790ad2860", | ||
| "endRef": "30d6ae6ba1230c5ab41937a5e05e8c3790ad2860" | ||
| }, | ||
| "completedAt": "2026-03-04T21:18:54.432Z", | ||
| "retrospective": { | ||
| "summary": "Patched publish.yml build-broker job to use cross for aarch64-unknown-linux-musl, removed musl.cc curl path, and enabled fail-fast=false for broker matrix", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.95 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Trajectory: Fix publish workflow musl.cc timeout for aarch64 broker build | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 95% | ||
| > **Started:** March 4, 2026 at 01:18 PM | ||
| > **Completed:** March 4, 2026 at 01:18 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Patched publish.yml build-broker job to use cross for aarch64-unknown-linux-musl, removed musl.cc curl path, and enabled fail-fast=false for broker matrix | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs | ||
| - **Chose:** Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs | ||
| - **Reasoning:** musl.cc timeouts cause recurring CI failures; cross uses maintained target container and avoids direct dependency on musl.cc | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs: Replaced publish workflow aarch64 musl toolchain download from musl.cc with cross-rs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "id": "traj_fxq5ufnzc3k3", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Reduce process-level CLI flake surface by keeping only smoke coverage in index.test" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-03-04T21:15:49.943Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-03-04T21:15:50.135Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_bsx5rxzuy2le", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-03-04T21:15:50.135Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1772658950135, | ||
| "type": "decision", | ||
| "content": "Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests: Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests", | ||
| "raw": { | ||
| "question": "Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests", | ||
| "chosen": "Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests", | ||
| "alternatives": [], | ||
| "reasoning": "unit tests already cover status/agents/who/history/read behavior deterministically; subprocess tests were flaky due broker startup timing" | ||
| }, | ||
| "significance": "high" | ||
| } | ||
| ], | ||
| "endedAt": "2026-03-04T21:15:50.309Z" | ||
| } | ||
| ], | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/Users/khaliqgant/Projects/agent-workforce/relay", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "be51324e0be71d973c950aab4a61b7bf96a0c151", | ||
| "endRef": "be51324e0be71d973c950aab4a61b7bf96a0c151" | ||
| }, | ||
| "completedAt": "2026-03-04T21:15:50.309Z", | ||
| "retrospective": { | ||
| "summary": "Trimmed index.test to version/help plus agents --json smoke; hardened smoke JSON detection against broker log prefixes", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.94 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Trajectory: Reduce process-level CLI flake surface by keeping only smoke coverage in index.test | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 94% | ||
| > **Started:** March 4, 2026 at 01:15 PM | ||
| > **Completed:** March 4, 2026 at 01:15 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Trimmed index.test to version/help plus agents --json smoke; hardened smoke JSON detection against broker log prefixes | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests | ||
| - **Chose:** Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests | ||
| - **Reasoning:** unit tests already cover status/agents/who/history/read behavior deterministically; subprocess tests were flaky due broker startup timing | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests: Removed broker-dependent subprocess assertions from index.test and relied on command/lib unit tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| { | ||
| "id": "traj_ygwd7ep8ab1e", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Stabilize flaky CLI agents --json test timeout" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-03-04T21:01:07.410Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-03-04T21:12:10.243Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_8fpb7wtgaj1m", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-03-04T21:12:10.243Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1772658730244, | ||
| "type": "decision", | ||
| "content": "Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests: Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests", | ||
| "raw": { | ||
| "question": "Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests", | ||
| "chosen": "Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests", | ||
| "alternatives": [], | ||
| "reasoning": "direct handler tests avoid broker startup/network timing and remove CI timeout flake while keeping one end-to-end smoke check" | ||
| }, | ||
| "significance": "high" | ||
| } | ||
| ], | ||
| "endedAt": "2026-03-04T21:12:10.460Z" | ||
| } | ||
| ], | ||
| "commits": [ | ||
| "be51324e", | ||
| "4e2a8934" | ||
| ], | ||
| "filesChanged": [ | ||
| ".github/workflows/build-broker-binary.yml", | ||
| ".trajectories/active/traj_ygwd7ep8ab1e.json", | ||
| ".trajectories/index.json", | ||
| "CHANGELOG.md", | ||
| "package-lock.json", | ||
| "package.json", | ||
| "packages/acp-bridge/package.json", | ||
| "packages/config/package.json", | ||
| "packages/hooks/package.json", | ||
| "packages/memory/package.json", | ||
| "packages/openclaw/package.json", | ||
| "packages/policy/package.json", | ||
| "packages/sdk-py/pyproject.toml", | ||
| "packages/sdk/package.json", | ||
| "packages/telemetry/package.json", | ||
| "packages/trajectory/package.json", | ||
| "packages/user-directory/package.json", | ||
| "packages/utils/package.json", | ||
| "src/cli/commands/agent-management.ts", | ||
| "src/cli/index.test.ts" | ||
| ], | ||
| "projectId": "/Users/khaliqgant/Projects/agent-workforce/relay", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "2c332bd4bbfdf971c3b424515d62493b0582a53f", | ||
| "endRef": "be51324e0be71d973c950aab4a61b7bf96a0c151", | ||
| "traceId": "trace_nbs8xyxldw67" | ||
| }, | ||
| "completedAt": "2026-03-04T21:12:10.460Z", | ||
| "retrospective": { | ||
| "summary": "Added deterministic unit tests for agent-management-listing and messaging history JSON; reduced CLI JSON integration surface to a single agents --json smoke test", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.93 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Trajectory: Stabilize flaky CLI agents --json test timeout | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 93% | ||
| > **Started:** March 4, 2026 at 01:01 PM | ||
| > **Completed:** March 4, 2026 at 01:12 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Added deterministic unit tests for agent-management-listing and messaging history JSON; reduced CLI JSON integration surface to a single agents --json smoke test | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests | ||
| - **Chose:** Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests | ||
| - **Reasoning:** direct handler tests avoid broker startup/network timing and remove CI timeout flake while keeping one end-to-end smoke check | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests: Moved agents/who/history JSON assertions from process-level CLI test to deterministic unit tests | ||
|
|
||
| --- | ||
|
|
||
| ## Artifacts | ||
|
|
||
| **Commits:** be51324e, 4e2a8934 | ||
| **Files changed:** 20 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 publish.yml aarch64 binary is never stripped due to missing cross-strip tool
The
stripcommand on line 125 runs the host's x86_64stripagainst a cross-compiled aarch64 binary, which silently fails (masked by|| true). The old code had a fallback toaarch64-linux-musl-strip, and the companion workflowbuild-broker-binary.yml:51-53correctly installsbinutils-aarch64-linux-gnuand usesaarch64-linux-gnu-stripfor the aarch64 case. The publish workflow omits both the package install and the cross-architecture strip invocation, so the aarch64 binary will be published unstripped (larger file size).Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.