Skip to content

fix install script#502

Merged
khaliqgant merged 3 commits intomainfrom
fix-install
Mar 6, 2026
Merged

fix install script#502
khaliqgant merged 3 commits intomainfrom
fix-install

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Mar 6, 2026

Summary

Test Plan

  • Tests added/updated
  • Manual testing completed

Screenshots


Open with Devin

@khaliqgant khaliqgant requested a review from willwashburn as a code owner March 6, 2026 19:24
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

The live GitHub API test was failing because the latest release tag
is `openclaw-v3.1.10` (a prefixed tag for the openclaw package), but
the regex only accepted `v*.*.*` patterns.

Updated the regex to accept versions with optional prefixes like
`openclaw-v3.1.10`, `broker-v1.2.3`, etc.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
devin-ai-integration[bot]

This comment was marked as resolved.

Apply Devin's code review suggestion: use ^([a-z]+-)?v?[0-9]+\.[0-9]+\.[0-9]+
instead of removing the ^ anchor entirely.

The previous fix was too permissive and would match any string containing
N.N.N anywhere (e.g., "garbage-1.2.3-not-a-version"). This fix properly
anchors the start while allowing lowercase prefixes like "openclaw-".

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@khaliqgant khaliqgant merged commit 3a3cb94 into main Mar 6, 2026
47 of 49 checks passed
@khaliqgant khaliqgant deleted the fix-install branch March 6, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant