fix: expose all workspace DM conversations in dashboard#510
Merged
khaliqgant merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
The /api/threads endpoint was using agent-scoped get_dms() which only returned DMs where the broker was a participant. Switch to workspace-level get_all_dms() using RelayCast::all_dm_conversations() + dm_messages() so all DM conversations between any agents are visible in the dashboard. Also enhance derive_thread_name() to use the participants array for "AgentA ↔ AgentB" display names on non-broker DM conversations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
xkonjin
reviewed
Mar 8, 2026
xkonjin
left a comment
xkonjin
left a comment
There was a problem hiding this comment.
Quick review pass:
- Main risk area here is connection lifecycle, retry behavior, and state re-initialization.
- I didn’t see targeted regression coverage in the diff; please add or point CI at a focused test for the changed path in main.rs, relaycast_ws.rs.
- Before merge, I’d smoke-test the behavior touched by main.rs, relaycast_ws.rs with malformed input / retry / rollback cases, since that’s where this class of change usually breaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/threadsused agent-scopedAgentClient::dm_messages_with_agent()which filters to only the broker's DMs.get_all_dms()method using workspace-levelRelayCast::all_dm_conversations()+dm_messages()to fetch ALL DM conversations. Enhancedderive_thread_name()to useparticipantsarray for "AgentA ↔ AgentB" display names.Changes
src/relaycast_ws.rs— Newget_all_dms()method with graceful fallbacksrc/main.rs:1899— Switched/api/threadshandler to useget_all_dms(200)src/main.rs:4879— Enhancedderive_thread_name()with participants-based namingTest plan
cargo test— all 228 tests passcargo clippy— 0 warningsbuild_thread_infos_shows_dms_between_non_broker_agentsbuild_thread_infos_dm_with_participants_filters_brokerbuild_thread_infos_multiple_independent_dm_conversations🤖 Generated with Claude Code