feat: wire workspaceName/relaycastBaseUrl options in AgentRelay#538
Merged
khaliqgant merged 3 commits intomainfrom Mar 10, 2026
Merged
feat: wire workspaceName/relaycastBaseUrl options in AgentRelay#538khaliqgant merged 3 commits intomainfrom
khaliqgant merged 3 commits intomainfrom
Conversation
Previously these options were stored but never used (dead code). Now they're wired up: - workspaceName: used as fallback for brokerName (the --name passed to the broker process) when brokerName is not explicitly set - relaycastBaseUrl: injected as RELAYCAST_BASE_URL into the broker subprocess environment, overriding the default api.relaycast.dev Addresses Devin comment r2864600988 on PR #460.
khaliqgant
force-pushed
the
fix/remove-unused-relay-options
branch
from
28c3f16 to
df05c72
Compare
khaliqgant
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Extracted wireRelaycastBaseUrl() helper and call it in all three code paths (cached key, env key, auto-create) so the custom base URL is always injected into the broker environment.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
khaliqgant
added a commit
that referenced
this pull request
Mar 25, 2026
* feat: wire workspaceName and relaycastBaseUrl options in AgentRelay Previously these options were stored but never used (dead code). Now they're wired up: - workspaceName: used as fallback for brokerName (the --name passed to the broker process) when brokerName is not explicitly set - relaycastBaseUrl: injected as RELAYCAST_BASE_URL into the broker subprocess environment, overriding the default api.relaycast.dev Addresses Devin comment r2864600988 on PR #460. * fix: wire relaycastBaseUrl in all ensureRelaycastApiKey branches Extracted wireRelaycastBaseUrl() helper and call it in all three code paths (cached key, env key, auto-create) so the custom base URL is always injected into the broker environment. * fix: explicit relaycastBaseUrl option overrides inherited env var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires up the previously dead
workspaceNameandrelaycastBaseUrloptions inAgentRelayOptions:workspaceName→ used as fallback forbrokerName(the--namepassed to the broker process). If you setworkspaceName: 'my-project'and don't setbrokerName, the broker starts with--name my-project.relaycastBaseUrl→ injected asRELAYCAST_BASE_URLinto the broker subprocess environment. Lets you point at a different Relaycast API endpoint (e.g., local dev, staging).Before: Both options were stored in the constructor but never read — dead code in the public API.
After: Both options are functional.
Build ✅ | Typecheck ✅
Addresses Devin comment r2864600988 on PR #460.