fix(sdk-swift): queue outbound messages during RelayObserver reconnect#646
Merged
Merged
Conversation
khaliqgant
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address follow-up review feedback from #627.
When
_handleSocketErroris entered from the receive-error path,isConnectionReadycould remaintrueduring the reconnect delay. That allowedsendChannel/sendDirectto write to a broken socket instead of queueing outbound messages for replay after reconnect.Fix
isConnectionReady = falseat the start of_handleSocketErrorWhy it matters
This ensures outbound messages are queued in
pendingOutboundwhile the observer is reconnecting, instead of being silently dropped.Follow-up to