Skip to content

fix(sdk-swift): queue outbound messages during RelayObserver reconnect#646

Merged
khaliqgant merged 1 commit into
mainfrom
fix/relayobserver-reconnect-ready-flag
Mar 26, 2026
Merged

fix(sdk-swift): queue outbound messages during RelayObserver reconnect#646
khaliqgant merged 1 commit into
mainfrom
fix/relayobserver-reconnect-ready-flag

Conversation

@miyaontherelay
Copy link
Copy Markdown
Contributor

@miyaontherelay miyaontherelay commented Mar 25, 2026

Summary

Address follow-up review feedback from #627.

When _handleSocketError is entered from the receive-error path, isConnectionReady could remain true during the reconnect delay. That allowed sendChannel / sendDirect to write to a broken socket instead of queueing outbound messages for replay after reconnect.

Fix

  • set isConnectionReady = false at the start of _handleSocketError

Why it matters

This ensures outbound messages are queued in pendingOutbound while the observer is reconnecting, instead of being silently dropped.

Follow-up to


Open with Devin

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@khaliqgant khaliqgant merged commit 59e77b2 into main Mar 26, 2026
34 checks passed
@khaliqgant khaliqgant deleted the fix/relayobserver-reconnect-ready-flag branch March 26, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants