Merged
Conversation
khaliqgant
force-pushed
the
resume-fallback
branch
from
c8ef40c to
1b42b65
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
runner.ts: fallback to relay.yaml when config undefined in resume() runner.ts: use fs.statSync mtime instead of synthetic timestamps runner.ts: add validateRunId() path traversal guard runner.ts: clarify failedStepName heuristic with comment runner.ts: scan .report.json files in cache reconstruction runner.ts: extract matchWorkflowFromCache() from nested ternary cli.ts: extract FLAGS_WITH_VALUES constant, add config drift warning cli.ts: simplify error matching with startsWith file-db.ts: check directory non-empty in hasStepOutputs() Co-Authored-By: My Senior Dev <dev@myseniordev.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
cli.ts: dead error message check fixed by startsWith() (already in 35c81e7) runner.ts: filter .report.json from cachedStepNames to prevent false cache hits Co-Authored-By: My Senior Dev <dev@myseniordev.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
workflow-runs.jsonlis missing (due to silent write failure infile-db.ts),--resumethrowsRun "X" not foundeven though all step outputs exist at.agent-relay/step-outputs/<runId>/. Meanwhile,--start-fromworks because it scans the filesystem viafindMostRecentRunWithSteps()andloadStepOutput().Solution Overview
Add a filesystem-based fallback to
resume()that reconstructs the run and step records from the step-output cache directory whendb.getRun()returns null.