Skip to content

fix: skip in-sandbox provisioning when cloud launcher already seeded ACLs #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 2 commits into from
Apr 10, 2026
Merged

fix: skip in-sandbox provisioning when cloud launcher already seeded ACLs #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95d1dd4
fix: skip in-sandbox provisioning when cloud launcher already seeded …
khaliqgant Apr 10, 2026
e0ed462
fix: rebuild before sdk e2e lifecycle phase
Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/sdk/src/workflows/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,6 +1545,13 @@ export class WorkflowRunner {
}

private async provisionAgents(config: RelayYamlConfig): Promise<void> {
// Cloud launcher already compiled and seeded relayfile ACLs before the
// sandbox started. Skip in-sandbox provisioning — the relayfile API has
// no POST /v1/workspaces route, so attempting it causes a fatal 404.
if (process.env.RELAY_CLOUD_PROVISIONING_DONE === '1') {
return;
}

this.agentTokens.clear();
await this.stopProvisionedMounts();

Expand Down
4 changes: 3 additions & 1 deletion scripts/e2e-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ if [ ! -f "$PROJECT_DIR/dist/src/cli/index.js" ]; then
log_info "Building project..."
npm run build
else
log_info "Build exists, skipping (run 'npm run build' to rebuild)"
log_info "Build exists, skipping initial rebuild (Phase 4 will rebuild before SDK lifecycle)"
fi

# Phase 1: Broker startup smoke test
Expand Down Expand Up @@ -305,6 +305,8 @@ fi

# Phase 4: SDK lifecycle test (spawn/list/release)
log_phase "Phase 4: SDK Agent Lifecycle"
log_info "Rebuilding before SDK lifecycle test to ensure dist matches current source..."
npm run build > /dev/null
if ! node "$PROJECT_DIR/scripts/e2e-sdk-lifecycle.mjs" \
--name "$AGENT_NAME" \
--cli "claude" \
Expand Down
Loading