Skip to content

Fix SDK trajectory publish build#742

Merged
khaliqgant merged 2 commits into
mainfrom
trajectory-incompat
Apr 15, 2026
Merged

Fix SDK trajectory publish build#742
khaliqgant merged 2 commits into
mainfrom
trajectory-incompat

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Apr 15, 2026

Summary

  • make the SDK workflow trajectory adapter compile against the publish-resolved agent-trajectories declarations while preserving workflow metadata, open-ended roles, and custom workflow event types
  • add a package-validation job that mimics publish dependency resolution by removing package-lock.json, running npm install, and building packages
  • record the work in the tracked trajectory files

Verification

  • NPM_CONFIG_IGNORE_SCRIPTS=false npm --prefix packages/sdk run build
  • temporary agent-trajectories@0.5.5 override + NPM_CONFIG_USERCONFIG=/dev/null npm --prefix packages/sdk run build
  • NPM_CONFIG_USERCONFIG=/dev/null npm run build:packages -- --force
  • npx prettier --check packages/sdk/src/workflows/trajectory.ts .github/workflows/package-validation.yml

Open with Devin

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 263162e3c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

run: npm install --no-save rollup || true

- name: Build packages
run: npm run build:packages
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Build full workspace in publish-resolution check

This job is documented as mirroring publish dependency resolution, but it only runs npm run build:packages, whereas the publish workflow’s fresh-install path runs npm run build (which also compiles the root CLI/TypeScript project). Because of that mismatch, a range-resolved dependency update that breaks only the root build can pass this new validation job and still fail during publish.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 15788b1: the publish-resolution CI job now runs npm run build instead of npm run build:packages, so it matches the publish workflow full root build path. Verified locally with NPM_CONFIG_USERCONFIG=/dev/null npm run build and npx prettier --check .github/workflows/package-validation.yml.

@khaliqgant khaliqgant merged commit 5117b80 into main Apr 15, 2026
40 checks passed
@khaliqgant khaliqgant deleted the trajectory-incompat branch April 15, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant