Fix SDK trajectory publish build#742
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 263162e3c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: npm install --no-save rollup || true | ||
|
|
||
| - name: Build packages | ||
| run: npm run build:packages |
There was a problem hiding this comment.
Build full workspace in publish-resolution check
This job is documented as mirroring publish dependency resolution, but it only runs npm run build:packages, whereas the publish workflow’s fresh-install path runs npm run build (which also compiles the root CLI/TypeScript project). Because of that mismatch, a range-resolved dependency update that breaks only the root build can pass this new validation job and still fail during publish.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in 15788b1: the publish-resolution CI job now runs npm run build instead of npm run build:packages, so it matches the publish workflow full root build path. Verified locally with NPM_CONFIG_USERCONFIG=/dev/null npm run build and npx prettier --check .github/workflows/package-validation.yml.
Summary
agent-trajectoriesdeclarations while preserving workflow metadata, open-ended roles, and custom workflow event typespackage-lock.json, runningnpm install, and building packagesVerification
NPM_CONFIG_IGNORE_SCRIPTS=false npm --prefix packages/sdk run buildagent-trajectories@0.5.5override +NPM_CONFIG_USERCONFIG=/dev/null npm --prefix packages/sdk run buildNPM_CONFIG_USERCONFIG=/dev/null npm run build:packages -- --forcenpx prettier --check packages/sdk/src/workflows/trajectory.ts .github/workflows/package-validation.yml