migration: relay on + provisioner SDK mint RS256 tokens via local JWKS#779
Merged
khaliqgant merged 3 commits intomainfrom Apr 24, 2026
Merged
migration: relay on + provisioner SDK mint RS256 tokens via local JWKS#779khaliqgant merged 3 commits intomainfrom
khaliqgant merged 3 commits intomainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Wrap goOnTheRelay body after createLocalJwks() in a top-level try/finally so the JWKS HTTP server is shut down even when ensureServices, requestWorkspaceSession, launchOnMount, or the FUSE setup throws. Removes the per-branch shutdown calls now handled by the outer finally. Addresses Devin review finding on #779. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
agent-relay ontoken minting and provisioner SDK token minting from HS256/shared-secret signing to RS256/private-key signing withkid.RELAYAUTH_JWKS_URLto local service, mount, and agent subprocess envs; agent envs also receive the local RS256 signing key metadata for nested workflow provisioning.{ privateKey, kid }signature.Why
Relayfile rejects HS256 after relayfile#60, and relayauth is purging HS256 support. The local
onflow needs tokens signed by a JWKS-backed RS256 key so local relayfile/relayauth verifiers can trust them.Breaking SDK change
mintAgentToken({ secret, ... })andWorkflowTokenFactory(secret, workspace, ...)now require RS256 signer inputs:{ privateKey, kid, ... }/new WorkflowTokenFactory(privateKey, kid, workspace, ...).provisionWorkflowAgents()now takestokenSigningKeyinstead ofsecret.Test plan
npx vitest run src/cli/commands/on/start.test.ts src/cli/commands/on/services.test.ts packages/sdk/src/provisioner/__tests__/token-factory.test.ts packages/sdk/src/provisioner/__tests__/token.test.ts packages/sdk/src/provisioner/__tests__/audit.test.ts packages/sdk/src/__tests__/provisioner-mount.test.tsnpx tsc -p packages/sdk/tsconfig.build.json --noEmitnpx tsx --test packages/sdk/src/provisioner/__tests__/token-factory.test.ts packages/sdk/src/provisioner/__tests__/token.test.ts packages/sdk/src/provisioner/__tests__/audit.test.tsnpm run buildnpx tsx src/cli/index.ts on --help