Skip to content

ci(publish): drop darwin-x64 smoke test#787

Merged
willwashburn merged 1 commit intomainfrom
ci/drop-darwin-x64-smoke
Apr 24, 2026
Merged

ci(publish): drop darwin-x64 smoke test#787
willwashburn merged 1 commit intomainfrom
ci/drop-darwin-x64-smoke

Conversation

@willwashburn
Copy link
Copy Markdown
Member

@willwashburn willwashburn commented Apr 24, 2026

GitHub's macos-13 (Intel) runner pool is capacity-constrained and routinely queues for hours, blocking releases. The x86_64-apple-darwin broker binary is still cross-compiled and published; we just no longer exercise it end-to-end in CI.


Open in Devin Review

GitHub's macos-13 (Intel) runner pool is capacity-constrained and
routinely queues for hours, blocking releases. The x86_64-apple-darwin
broker binary is still cross-compiled and published; we just no longer
exercise it end-to-end in CI.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces release pipeline latency by removing the end-to-end CI smoke test for the Intel macOS (macos-13) runner, which is frequently capacity-constrained, while continuing to cross-compile and publish the x86_64-apple-darwin broker binary.

Changes:

  • Removed the darwin-x64 leg from the smoke-broker-packages CI matrix.
  • Added inline workflow commentary explaining why the darwin-x64 smoke test is intentionally omitted.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +547 to +550
# darwin-x64 smoke is intentionally omitted: GitHub's macos-13
# (Intel) runner pool is capacity-constrained and routinely queues
# for hours. The x86_64-apple-darwin broker binary is still
# cross-compiled and published; we just don't exercise it in CI.
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header comment for smoke-broker-packages (above this matrix) states the smoke test runs "on every target platform", but this change intentionally omits darwin-x64. Please update that earlier comment to avoid misleading future readers about CI coverage.

Copilot uses AI. Check for mistakes.
@willwashburn willwashburn merged commit 85ad5fa into main Apr 24, 2026
40 checks passed
@willwashburn willwashburn deleted the ci/drop-darwin-x64-smoke branch April 24, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants