Skip to content

fix(ci): publish SDK internal deps before sdk#806

Merged
khaliqgant merged 2 commits intomainfrom
fix/publish-sdk-internal-deps
Apr 30, 2026
Merged

fix(ci): publish SDK internal deps before sdk#806
khaliqgant merged 2 commits intomainfrom
fix/publish-sdk-internal-deps

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Apr 30, 2026

Summary

  • publish required SDK internal packages (config, github-primitive, workflow-types) during package=sdk releases before publishing @agent-relay/sdk
  • skip already-published internal package versions so reruns can repair a missing package without failing on existing ones
  • include the same internal deps in sdk dry-run validation

Why

@agent-relay/sdk@6.0.4 depends on @agent-relay/workflow-types@6.0.4, but that package was not published, so runtime imports of @agent-relay/sdk/workflows fail with Cannot find module @agent-relay/workflow-types. PR #804 fixed the package=all path; this covers the package=sdk path and lets reruns publish a missing internal dep idempotently.

Validation

  • ruby -e "require 'yaml'; YAML.load_file('.github/workflows/publish.yml'); puts 'YAML_OK'"\n- npm --prefix packages/workflow-types run build\n- (cd packages/workflow-types && npm pack --ignore-scripts --pack-destination "$tmp") verified tarball contains dist/index.js, dist/index.d.ts, source maps, and package.json

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread .github/workflows/publish.yml
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d003c729f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1066 to +1068
if npm view "${name}@${VERSION}" version >/dev/null 2>&1; then
echo "✓ ${name}@${VERSION} is already published"
return
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Skip SDK publish when version is already on npm

The new idempotency check only guards config, github-primitive, and workflow-types; the workflow still always runs npm publish for @agent-relay/sdk. In the exact recovery case this change targets (rerun with the same version after SDK was already published but an internal dep was missing), the internal dep can be repaired but the job still fails at SDK publish because npm rejects republishing an existing name/version. Add the same existence check (or a dist-tag update path) for SDK so reruns can complete successfully.

Useful? React with 👍 / 👎.

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@khaliqgant khaliqgant merged commit 7daddd5 into main Apr 30, 2026
10 checks passed
@khaliqgant khaliqgant deleted the fix/publish-sdk-internal-deps branch April 30, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant