Skip to content

fix(personas): bump agent-relay-workflow writer timeouts#857

Merged
khaliqgant merged 1 commit into
mainfrom
fix/agent-relay-workflow-writer-timeout
May 15, 2026
Merged

fix(personas): bump agent-relay-workflow writer timeouts#857
khaliqgant merged 1 commit into
mainfrom
fix/agent-relay-workflow-writer-timeout

Conversation

@kjgbot
Copy link
Copy Markdown
Contributor

@kjgbot kjgbot commented May 15, 2026

Summary

Ricky's writer SIGTERM'd at the 20-min mark while authoring a 12-PR spec (cloud#657), producing a partial workflow with zero @agent-relay/github-primitive PR-shipping steps. The previous tier budgets (best 1200s, best-value 900s, minimum 700s) are too tight for medium-to-large specs.

Bumps harnessSettings.timeoutSeconds on the agent-relay-workflow persona:

Tier Before After
best 1200s (20 min) 3600s (60 min)
best-value 900s (15 min) 3600s (60 min)
minimum 700s (~12 min) 1800s (30 min)

Why this size

  • The writer must read the spec, choose a coordination pattern, draft a structurally-valid workflow with deterministic preflight/context, bounded implementation steps, review, fix-loop, hard validation, regression evidence, and GitHub-primitive PR shipping steps. For specs with 5+ PR sections or detailed architecture tables this consistently exceeds 15-20 min on opencode/gpt-5-nano and openai-codex/gpt-5.3-codex.
  • 60 min is generous but not absurd given the per-tier model's typical streaming cadence and the persona's quality contract (artifact must be complete TypeScript, not a plan/outline).
  • minimum stays smaller (30 min) to encourage spec splitting for that tier rather than driving very large specs through the cheapest model.

Mitigation in the meantime

  • Splitting parent specs into per-track sub-specs (see cloud#657) is the structural fix — even at the old budgets, single-PR sub-specs finish comfortably.
  • This PR is the cost floor adjustment for cases where splitting isn't ergonomic.

Validation

  • npm run --workspace packages/personas validatevalidated 8 persona file(s), 0 failure(s).

Test plan

  • After this lands and @agent-relay/personas republishes, the workload-router-bundled agentRelayWorkflow.tiers.*.harnessSettings.timeoutSeconds should reflect the new values on next ricky --mode local run.
  • Re-run a large spec (e.g. specs/mcp-cloud-spawn-and-slack-bridge.md from cloud#657) and confirm the writer reaches completion rather than SIGTERM at 20 min.

Out of scope

  • The "Ricky-local Claude persona override" that swaps opencode/gpt-5-nanoclaude --model claude-sonnet-4-6 at runtime. If that override sets its own timeoutSeconds (not yet confirmed), it should be patched separately in ricky.

🤖 Generated with Claude Code

Ricky's writer SIGTERM'd at the 20-min mark while authoring a 12-PR
spec, producing a partial workflow with zero @agent-relay/github-primitive
PR-shipping steps. The previous tier budgets (best 1200s, best-value
900s, minimum 700s) are too tight for medium-to-large specs.

Bumps:
- best:       1200s →  3600s (60 min)
- best-value:  900s →  3600s (60 min)
- minimum:     700s →  1800s (30 min)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a18e529e-f231-44b6-aa78-90fde0cc3a73

📥 Commits

Reviewing files that changed from the base of the PR and between a7ef2fc and c435098.

📒 Files selected for processing (1)
  • packages/personas/personas/agent-relay-workflow.json

📝 Walkthrough

Walkthrough

Workflow tier harness timeout configurations are increased across all performance tiers in the agent relay configuration. The best tier timeout grows from 1200 to 3600 seconds, best-value from 900 to 3600 seconds, and minimum from 700 to 1800 seconds, while reasoning levels remain unchanged.

Changes

Workflow Tier Timeout Configuration

Layer / File(s) Summary
Timeout settings for all tiers
packages/personas/personas/agent-relay-workflow.json
harnessSettings.timeoutSeconds is increased for all three performance tiers: best (1200 → 3600), best-value (900 → 3600), and minimum (700 → 1800), with reasoning settings unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit's whisper on the timeout quest,
Three tiers now breathe with moments to rest,
From hurried hops to leisured strides—
More time for thought, no rush to hide! 🐰⏰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: bumping timeout values in the agent-relay-workflow persona configuration.
Description check ✅ Passed The description comprehensively covers the template sections with detailed summary, rationale, validation results, and test plan; all required elements are present and well-articulated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/agent-relay-workflow-writer-timeout

Comment @coderabbitai help to get the list of available commands and usage tips.

@khaliqgant khaliqgant merged commit 208b425 into main May 15, 2026
41 checks passed
@khaliqgant khaliqgant deleted the fix/agent-relay-workflow-writer-timeout branch May 15, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants