Remove stale root bin fallback#905
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRemoves ancestor/repository-root ChangesLegacy bin fallback removal from binary resolution
Sequence Diagram(s)sequenceDiagram
participant Caller
participant BrokerPath
participant OptionalDepPackage
participant DevTargets
Caller->>BrokerPath: getBrokerBinaryPath()
BrokerPath->>OptionalDepPackage: check optional-dep package path
BrokerPath->>DevTargets: check development target paths (target/release, target/debug)
BrokerPath->>Caller: PATH lookup / return resolved path
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/sdk/src/broker-path.ts (1)
270-277:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix stale PATH step numbering in resolver comments.
Line 277 still says
// 7. PATH lookup, but the documented sequence now ends at step 6 after the fallback removal.Suggested patch
- // 7. PATH lookup + // 6. PATH lookup🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/sdk/src/broker-path.ts` around lines 270 - 277, Update the stale comment numbering in the resolver sequence: change the comment "// 7. PATH lookup" to "// 6. PATH lookup" (or otherwise renumber to match the current sequence) near the loop that iterates getDevelopmentBinaryPaths(ext, binDirs) and the existsSync(developmentPath) check so the step numbers reflect the actual order after the fallback removal; ensure any adjacent step comments are consistent with this renumbering.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/sdk/src/broker-path.ts`:
- Around line 270-277: Update the stale comment numbering in the resolver
sequence: change the comment "// 7. PATH lookup" to "// 6. PATH lookup" (or
otherwise renumber to match the current sequence) near the loop that iterates
getDevelopmentBinaryPaths(ext, binDirs) and the existsSync(developmentPath)
check so the step numbers reflect the actual order after the fallback removal;
ensure any adjacent step comments are consistent with this renumbering.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ae2ea59f-a9b6-4887-8e8f-9a9eefc23499
📒 Files selected for processing (10)
.trajectories/completed/2026-05/traj_sqerp89tc436.json.trajectories/completed/2026-05/traj_sqerp89tc436.md.trajectories/index.jsonbin/.gitkeeppackage.jsonpackages/sdk/src/__tests__/broker-path.test.tspackages/sdk/src/broker-path.tspackages/utils/src/relay-pty-path.test.tspackages/utils/src/relay-pty-path.tsscripts/build-release.sh
💤 Files with no reviewable changes (1)
- scripts/build-release.sh
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…in-fallback # Conflicts: # .trajectories/index.json Co-authored-by: willwashburn <957608+willwashburn@users.noreply.github.com>
Contributor
Resolved and merged the branch with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Removes the empty repository-root bin placeholder and stale resolver probes for it; keeps active SDK bin, optional broker package, Cargo, installer, and system lookup paths. Updates build/release scripts and tests to stop assuming a root bin artifact. Tests: npx vitest run packages/sdk/src/tests/broker-path.test.ts packages/utils/src/relay-pty-path.test.ts; npx vitest run src/tests/broker-path.test.ts (from packages/sdk); npm run build:utils; npm run build:sdk; git diff --check.