chore: prune unused root dependencies#948
Open
willwashburn wants to merge 4 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughReplace root dependency set by adding ChangesDependency Cleanup and Validation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…ncy-cleanup # Conflicts: # .trajectories/index.json # package-lock.json
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.trajectories/completed/2026-05/traj_78ytpicts778.md:
- Line 12: Replace the ambiguous wildcard-style token notation
"AGENT*RELAY_RESULT*_" with the clear underscore-based form
"AGENT_RELAY_RESULT*_" everywhere in the narrative and config mentions
(Gemini/Droid mcp add, opencode.json, .cursor/mcp.json and the inline Codex
result env references), ensuring all occurrences use the exact environment
variable name and consistent formatting; leave the note about skipping the
skip*relay_prompt finding as-is but update its description to reference
AGENT_RELAY_RESULT*_ consistently as well.
In @.trajectories/index.json:
- Line 311: The index contains host-specific absolute "path" values (e.g.
"/Users/will/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_1rrpe2r7fyem.json")
which must be normalized to repo-relative paths; update the "path" value for
that entry and the other listed entries (332, 550, 606, 719, 1014, 1154, 1161,
1168, 1175, 1182, 1189) to use stable repo-relative strings like
".trajectories/completed/2026-05/traj_1rrpe2r7fyem.json" so the index no longer
contains local filesystem details.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1e309f0b-b7f3-43d7-a812-df68375eef4f
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (7)
.trajectories/completed/2026-05/traj_5k0jtc1g5l33.md.trajectories/completed/2026-05/traj_78ytpicts778.json.trajectories/completed/2026-05/traj_78ytpicts778.md.trajectories/completed/2026-05/traj_90jmd9z27oap.json.trajectories/completed/2026-05/traj_90jmd9z27oap.md.trajectories/index.jsonpackage.json
💤 Files with no reviewable changes (1)
- package.json
✅ Files skipped from review due to trivial changes (4)
- .trajectories/completed/2026-05/traj_90jmd9z27oap.md
- .trajectories/completed/2026-05/traj_78ytpicts778.json
- .trajectories/completed/2026-05/traj_90jmd9z27oap.json
- .trajectories/completed/2026-05/traj_5k0jtc1g5l33.md
| ## Summary | ||
|
|
||
| Verified PR 932 review findings. Fixed the valid shared-config token persistence issue by omitting AGENT_RELAY_RESULT_* from Gemini/Droid mcp add, opencode.json, and .cursor/mcp.json while retaining inline Codex result env. Skipped the skip_relay_prompt finding because current worker spawn already sets AGENT_RELAY_RESULT_* on the worker process even when MCP prompt injection is skipped. | ||
| Verified PR 932 review findings. Fixed the valid shared-config token persistence issue by omitting AGENT*RELAY_RESULT*_ from Gemini/Droid mcp add, opencode.json, and .cursor/mcp.json while retaining inline Codex result env. Skipped the skip*relay_prompt finding because current worker spawn already sets AGENT_RELAY_RESULT*_ on the worker process even when MCP prompt injection is skipped. |
Contributor
There was a problem hiding this comment.
Fix malformed token notation in narrative text.
The current AGENT*RELAY_RESULT*_ / AGENT_RELAY_RESULT*_ formatting is ambiguous in Markdown and can miscommunicate the exact token/env var name.
Suggested text cleanup
-Verified PR 932 review findings. Fixed the valid shared-config token persistence issue by omitting AGENT*RELAY_RESULT*_ from Gemini/Droid mcp add, opencode.json, and .cursor/mcp.json while retaining inline Codex result env. Skipped the skip*relay_prompt finding because current worker spawn already sets AGENT_RELAY_RESULT*_ on the worker process even when MCP prompt injection is skipped.
+Verified PR 932 review findings. Fixed the valid shared-config token persistence issue by omitting `AGENT_RELAY_RESULT` from Gemini/Droid mcp add, opencode.json, and .cursor/mcp.json while retaining inline Codex result env. Skipped the `skip_relay_prompt` finding because current worker spawn already sets `AGENT_RELAY_RESULT` on the worker process even when MCP prompt injection is skipped.-- **Reasoning:** The result callback token is per spawn. Gemini/Droid mcp add, opencode.json, and .cursor/mcp.json are shared or persistent surfaces, so those paths now omit AGENT*RELAY_RESULT*\* and rely on inline configs or worker process env instead.
+- **Reasoning:** The result callback token is per spawn. Gemini/Droid mcp add, opencode.json, and .cursor/mcp.json are shared or persistent surfaces, so those paths now omit `AGENT_RELAY_RESULT` and rely on inline configs or worker process env instead.Also applies to: 23-23
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 12-12: Spaces inside emphasis markers
(MD037, no-space-in-emphasis)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.trajectories/completed/2026-05/traj_78ytpicts778.md at line 12, Replace the
ambiguous wildcard-style token notation "AGENT*RELAY_RESULT*_" with the clear
underscore-based form "AGENT_RELAY_RESULT*_" everywhere in the narrative and
config mentions (Gemini/Droid mcp add, opencode.json, .cursor/mcp.json and the
inline Codex result env references), ensuring all occurrences use the exact
environment variable name and consistent formatting; leave the note about
skipping the skip*relay_prompt finding as-is but update its description to
reference AGENT_RELAY_RESULT*_ consistently as well.
| "status": "completed", | ||
| "startedAt": "2026-05-20T07:20:33.009Z", | ||
| "completedAt": "2026-05-20T07:26:17.567Z", | ||
| "path": "/Users/will/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_1rrpe2r7fyem.json" |
Contributor
There was a problem hiding this comment.
Normalize trajectory path values to repo-relative paths.
Several newly added entries store host-specific absolute paths (/Users/..., /home/runner/..., /private/tmp/...). Since this index is shared and read as source-of-truth, these paths are non-portable and leak local filesystem details.
Use stable repo-relative paths (for example: .trajectories/completed/2026-05/<id>.json) for all newly added entries.
Also applies to: 332-332, 550-550, 606-606, 719-719, 1014-1014, 1154-1154, 1161-1161, 1168-1168, 1175-1175, 1182-1182, 1189-1189
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.trajectories/index.json at line 311, The index contains host-specific
absolute "path" values (e.g.
"/Users/will/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_1rrpe2r7fyem.json")
which must be normalized to repo-relative paths; update the "path" value for
that entry and the other listed entries (332, 550, 606, 719, 1014, 1154, 1161,
1168, 1175, 1182, 1189) to use stable repo-relative strings like
".trajectories/completed/2026-05/traj_1rrpe2r7fyem.json" so the index no longer
contains local filesystem details.
…ncy-cleanup # Conflicts: # .trajectories/index.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Confirmation
Validation