ci(config): use workspace tsc instead of network-fetched typescript#985
Conversation
`packages/config` was the only workspace package whose build invoked `npx -p typescript@5.7.3 tsc`, reaching out to the npm registry on every turbo cache miss. A transient registry hiccup during Package Validation on main (run 26379771304) failed the build step while the fresh-install and macOS smoke jobs — which build the same workspace via different paths — both passed. Align with the rest of the workspace: declare `typescript` as a local devDependency (matching the hoisted root pin) and run `tsc` directly so the build no longer depends on network availability.
|
Warning Review limit reached
Your plan includes 4 reviews of capacity. Refill in 7 minutes and 1 second. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
2 participants
Summary
packages/configwas the only workspace package whose build invokednpx -p typescript@5.7.3 tsc, reaching out to the npm registry on every turbo cache miss. Every other package (acp-bridge,github-primitive,browser-primitive,policy,cloud,telemetry,events,workflow-types, …) runstscdirectly against a workspace-hoisted compiler.That network dependency is the most plausible cause of the recent Package Validation failure on main: run 26379771304. The
Build & Validatejob failed atBuild packages, whilePublish Fresh Install BuildandStandalone macOS Smoke— both of which build the same workspace through different paths — passed in the same run. The triggering merge commit (PR #979) only bumpsquinn-protoinCargo.lock, so there is no code change to explain a real build break.Changes
packages/config/package.json:"build": "npx -p typescript@5.7.3 tsc"→"build": "tsc", and declaretypescript: ^5.9.3as a local devDependency (matches the root workspace pin).package-lock.json: refreshed.Test plan
rm -rf packages/config/dist && (cd packages/config && npx tsc)rebuilds the package cleanly.Generated by Claude Code