Skip to content

transform logic#12

Merged
khaliqgant merged 4 commits into
mainfrom
transform-ws
Feb 10, 2026
Merged

transform logic#12
khaliqgant merged 4 commits into
mainfrom
transform-ws

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Feb 10, 2026

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review

Comment thread packages/server/src/ws/transform.ts Outdated
khaliqgant added a commit that referenced this pull request Feb 10, 2026
…t case

- Fix pubsub listener to route by data.channel_name instead of channel_id
  (clients subscribe by name, not DB snowflake ID)
- Default transform case now strips workspace_id/channel_id/timestamp/data
  instead of leaking them to clients (addresses PR #12 review feedback)
- Add E2E WebSocket test script (scripts/e2e-ws.ts)
- Update broker-compat test to use realistic DB ID for channel_id

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
khaliqgant and others added 2 commits February 10, 2026 13:27
…t case

- Fix pubsub listener to route by data.channel_name instead of channel_id
  (clients subscribe by name, not DB snowflake ID)
- Default transform case now strips workspace_id/channel_id/timestamp/data
  instead of leaking them to clients (addresses PR #12 review feedback)
- Add E2E WebSocket test script (scripts/e2e-ws.ts)
- Update broker-compat test to use realistic DB ID for channel_id

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 new potential issues.

View 7 additional findings in Devin Review.

Open in Devin Review

Comment thread packages/server/src/ws/transform.ts
Comment thread packages/server/src/ws/transform.ts
Comment thread packages/server/src/ws/transform.ts
khaliqgant and others added 2 commits February 10, 2026 13:29
PR #11 added message handler and subscribeToWorkspace at the top of
handleUpgrade but the originals at the bottom were not removed, causing
handleClientMessage to fire twice per message (breaking unsubscribe).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ion, group DM

- reaction.removed: add agent_name to event data (transform reads it)
- thread.reply: add from_name to event data (transform reads it)
- group_dm.received: add from_name to event data (transform reads it)

Addresses PR #12 review feedback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@khaliqgant khaliqgant merged commit be9dec6 into main Feb 10, 2026
1 check passed
@khaliqgant khaliqgant deleted the transform-ws branch February 10, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant