Conversation
|
Preview deployed!
This preview shares the staging database and will be cleaned up when the PR is merged or closed. Run E2E testsnpm run e2e -- https://pr121-api.relaycast.dev --ciOpen observer dashboard |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7aa87fc211
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .map((term) => term.trim()) | ||
| .filter(Boolean); | ||
|
|
||
| if (terms.length === 0) return 1; | ||
| return terms.every((term) => haystack.includes(term)) ? 1 : 0; |
There was a problem hiding this comment.
Strip phrase quotes before fallback term matching
When FTS5 is unavailable, fts_match currently checks haystack.includes(term) on terms that still contain " characters from buildFtsQuery, so a query like "subscription billing" is split into quoted fragments and never matches normal text. This makes Node 22.14 fallback behavior diverge from real FTS5 (which supports phrase queries), so directory/routing tests can report false negatives only in the fallback path and miss regressions in query handling.
Useful? React with 👍 / 👎.
Summary
Verification
Why CI Missed It
PR/deploy CI used floating node-version: 22, while publish was pinned to Node 22.14.0. Newer Node 22 patches include the SQLite APIs/features these tests assumed; Node 22.14.0 does not.