Skip to content

ci: publish @relaycast/engine in lockstep; remove publish-engine workflow#152

Merged
willwashburn merged 3 commits into
mainfrom
ci/engine-lockstep-publish
Jun 1, 2026
Merged

ci: publish @relaycast/engine in lockstep; remove publish-engine workflow#152
willwashburn merged 3 commits into
mainfrom
ci/engine-lockstep-publish

Conversation

@willwashburn
Copy link
Copy Markdown
Member

Summary

Fold @relaycast/engine into the lockstep @relaycast/* publish so it's versioned and released with the rest of the packages, and remove the separate manual publish workflow.

  • publish-npm.yml: include engine in the version-bump sweep (drop the SKIP = new Set(['engine']) exclusion and the !== '@relaycast/engine' dependency-rewrite carve-out), and add engine to the publish matrix, the workflow_dispatch package options, and the summary table.
  • Delete publish-engine.yml (the independent, manually-dispatched engine publish).

Verified the version-sweep script now bumps @relaycast/engine and rewrites internal @relaycast/* deps for all packages; the three touched workflows parse as valid YAML.

Heads up: feat/engine-package also carries an equivalent change (14bdc34 "ci: fold engine publish into publish-npm workflow"). Whichever lands first, the other should drop its copy to avoid a conflict.

Context

This re-lands a change that briefly went directly to main (1ec80ab) by mistake while #151 was merging; that commit was reverted on main (e9e4651) and is re-submitted here for normal review.

🤖 Generated with Claude Code

…orkflow

The engine is no longer versioned/released independently — fold it into the
lockstep @relaycast/* publish:
- publish-npm.yml: add `engine` to the version-bump sweep (drop the SKIP set and
  the `!== '@relaycast/engine'` dependency-rewrite exclusion) and to the publish
  matrix, dispatch options, and summary table.
- Delete the custom publish-engine.yml workflow.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Warning

Review limit reached

@agent-relay-bot[bot], we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 20 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 756a8d2c-150a-4659-becc-ac0f87522b6a

📥 Commits

Reviewing files that changed from the base of the PR and between e9e4651 and 5f36d69.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .github/workflows/publish-engine.yml
  • .github/workflows/publish-npm.yml
  • .trajectories/index.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/engine-lockstep-publish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82a5b8ce7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/publish-npm.yml Outdated
- all
- a2a
- types
- engine
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove engine from single-package choices

When package: engine is selected, this workflow takes the publish-single path and publishes only packages/engine, but the build step now rewrites every @relaycast/* dependency to the new lockstep version. That means @relaycast/engine@NEW_VERSION is published with exact dependencies such as @relaycast/a2a@NEW_VERSION and @relaycast/types@NEW_VERSION that were not published by this run, making the engine package uninstallable unless those versions already happened to exist. Either keep engine out of single-package dispatch or make the engine option publish its lockstep dependencies too.

Useful? React with 👍 / 👎.

@agent-relay-bot
Copy link
Copy Markdown
Contributor

Updated PR #152 locally.

Changes made:

  • Hardened .github/workflows/publish-npm.yml so custom_version and NEW_VERSION are passed through environment variables instead of interpolated into shell/inline JS.
  • Added @relaycast/engine to the generated release install snippet, matching the new lockstep package table.

Local checks:

  • npm ci
  • Workflow YAML parse and extracted version-step bash -n
  • Version step simulation in a temp copy confirmed all workspace versions and internal @relaycast/* deps sync, including engine
  • npx turbo build/test/lint --filter=@relaycast/engine
  • Non-dashboard serial test/lint pass succeeded
  • Full build reached the private Next dashboard and was killed with exit 137 in this container; package-level builds for affected/relevant packages passed directly.

Copy link
Copy Markdown
Contributor

@agent-relay-bot agent-relay-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-reviewer applied fixes — committed and pushed 2620f09 to this PR. The notes below describe what changed.

Updated PR #152 locally.

Changes made:

  • Hardened .github/workflows/publish-npm.yml so custom_version and NEW_VERSION are passed through environment variables instead of interpolated into shell/inline JS.
  • Added @relaycast/engine to the generated release install snippet, matching the new lockstep package table.

Local checks:

  • npm ci
  • Workflow YAML parse and extracted version-step bash -n
  • Version step simulation in a temp copy confirmed all workspace versions and internal @relaycast/* deps sync, including engine
  • npx turbo build/test/lint --filter=@relaycast/engine
  • Non-dashboard serial test/lint pass succeeded
  • Full build reached the private Next dashboard and was killed with exit 137 in this container; package-level builds for affected/relevant packages passed directly.

@agent-relay-bot
Copy link
Copy Markdown
Contributor

pr-reviewer applied fixes — committed and pushed 2620f09 to this PR. The notes below describe what changed.

Updated PR #152 locally.

Changes made:

  • Hardened .github/workflows/publish-npm.yml so custom_version and NEW_VERSION are passed through environment variables instead of interpolated into shell/inline JS.
  • Added @relaycast/engine to the generated release install snippet, matching the new lockstep package table.

Local checks:

  • npm ci
  • Workflow YAML parse and extracted version-step bash -n
  • Version step simulation in a temp copy confirmed all workspace versions and internal @relaycast/* deps sync, including engine
  • npx turbo build/test/lint --filter=@relaycast/engine
  • Non-dashboard serial test/lint pass succeeded
  • Full build reached the private Next dashboard and was killed with exit 137 in this container; package-level builds for affected/relevant packages passed directly.

@agent-relay-bot
Copy link
Copy Markdown
Contributor

pr-reviewer applied fixes — committed and pushed 5f36d69 to this PR. The notes below describe what changed.

Fixed the actionable review finding in .github/workflows/publish-npm.yml: engine is no longer a manual single-package publish option, but remains in the all publish matrix. That prevents publishing @relaycast/engine alone after lockstep dependency rewrites.

Local checks run:

  • npx prettier --check .github/workflows/publish-npm.yml
  • Node YAML/workflow shape check confirming engine absent from single choices and present in the all-package matrix
  • npx turbo build --filter=... for all public packages
  • npx turbo test --filter=... for all public packages
  • npx turbo lint --filter=@relaycast/engine

Copy link
Copy Markdown
Contributor

@agent-relay-bot agent-relay-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-reviewer applied fixes — committed and pushed 5f36d69 to this PR. The notes below describe what changed.

Fixed the actionable review finding in .github/workflows/publish-npm.yml: engine is no longer a manual single-package publish option, but remains in the all publish matrix. That prevents publishing @relaycast/engine alone after lockstep dependency rewrites.

Local checks run:

  • npx prettier --check .github/workflows/publish-npm.yml
  • Node YAML/workflow shape check confirming engine absent from single choices and present in the all-package matrix
  • npx turbo build --filter=... for all public packages
  • npx turbo test --filter=... for all public packages
  • npx turbo lint --filter=@relaycast/engine

@willwashburn willwashburn merged commit 8e167e5 into main Jun 1, 2026
5 checks passed
@willwashburn willwashburn deleted the ci/engine-lockstep-publish branch June 1, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant