ci: publish @relaycast/engine in lockstep; remove publish-engine workflow#152
Conversation
…orkflow The engine is no longer versioned/released independently — fold it into the lockstep @relaycast/* publish: - publish-npm.yml: add `engine` to the version-bump sweep (drop the SKIP set and the `!== '@relaycast/engine'` dependency-rewrite exclusion) and to the publish matrix, dispatch options, and summary table. - Delete the custom publish-engine.yml workflow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Review limit reached
More reviews will be available in 12 minutes and 20 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82a5b8ce7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - all | ||
| - a2a | ||
| - types | ||
| - engine |
There was a problem hiding this comment.
Remove engine from single-package choices
When package: engine is selected, this workflow takes the publish-single path and publishes only packages/engine, but the build step now rewrites every @relaycast/* dependency to the new lockstep version. That means @relaycast/engine@NEW_VERSION is published with exact dependencies such as @relaycast/a2a@NEW_VERSION and @relaycast/types@NEW_VERSION that were not published by this run, making the engine package uninstallable unless those versions already happened to exist. Either keep engine out of single-package dispatch or make the engine option publish its lockstep dependencies too.
Useful? React with 👍 / 👎.
|
Updated PR #152 locally. Changes made:
Local checks:
|
There was a problem hiding this comment.
✅ pr-reviewer applied fixes — committed and pushed 2620f09 to this PR. The notes below describe what changed.
Updated PR #152 locally.
Changes made:
- Hardened
.github/workflows/publish-npm.ymlsocustom_versionandNEW_VERSIONare passed through environment variables instead of interpolated into shell/inline JS. - Added
@relaycast/engineto the generated release install snippet, matching the new lockstep package table.
Local checks:
npm ci- Workflow YAML parse and extracted version-step
bash -n - Version step simulation in a temp copy confirmed all workspace versions and internal
@relaycast/*deps sync, including engine npx turbo build/test/lint --filter=@relaycast/engine- Non-dashboard serial test/lint pass succeeded
- Full build reached the private Next dashboard and was killed with exit 137 in this container; package-level builds for affected/relevant packages passed directly.
|
✅ pr-reviewer applied fixes — committed and pushed Updated PR #152 locally. Changes made:
Local checks:
|
|
✅ pr-reviewer applied fixes — committed and pushed Fixed the actionable review finding in .github/workflows/publish-npm.yml: Local checks run:
|
There was a problem hiding this comment.
✅ pr-reviewer applied fixes — committed and pushed 5f36d69 to this PR. The notes below describe what changed.
Fixed the actionable review finding in .github/workflows/publish-npm.yml: engine is no longer a manual single-package publish option, but remains in the all publish matrix. That prevents publishing @relaycast/engine alone after lockstep dependency rewrites.
Local checks run:
npx prettier --check .github/workflows/publish-npm.yml- Node YAML/workflow shape check confirming
engineabsent from single choices and present in the all-package matrix npx turbo build --filter=...for all public packagesnpx turbo test --filter=...for all public packagesnpx turbo lint --filter=@relaycast/engine
Summary
Fold
@relaycast/engineinto the lockstep@relaycast/*publish so it's versioned and released with the rest of the packages, and remove the separate manual publish workflow.publish-npm.yml: includeenginein the version-bump sweep (drop theSKIP = new Set(['engine'])exclusion and the!== '@relaycast/engine'dependency-rewrite carve-out), and addengineto the publish matrix, theworkflow_dispatchpackage options, and the summary table.publish-engine.yml(the independent, manually-dispatched engine publish).Verified the version-sweep script now bumps
@relaycast/engineand rewrites internal@relaycast/*deps for all packages; the three touched workflows parse as valid YAML.Context
This re-lands a change that briefly went directly to
main(1ec80ab) by mistake while #151 was merging; that commit was reverted onmain(e9e4651) and is re-submitted here for normal review.🤖 Generated with Claude Code