Skip to content

support automatic api key auth with key in query param#64

Merged
khaliqgant merged 2 commits intomainfrom
observer-with-api-key
Feb 27, 2026
Merged

support automatic api key auth with key in query param#64
khaliqgant merged 2 commits intomainfrom
observer-with-api-key

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Feb 27, 2026

Allows https://observer.relaycast.dev/?key=rk_live_599b9a48a50cfb51bdacfa38fef9f2d6 to work for a user to view the observer dashboard easily


Open with Devin

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@github-actions
Copy link
Copy Markdown

Preview deployed!

Environment URL
API https://pr64-api.relaycast.dev
Health https://pr64-api.relaycast.dev/health
Observer https://pr64-observer.relaycast.dev

This preview shares the staging database and will be cleaned up when the PR is merged or closed.

Run E2E tests

npm run e2e -- https://pr64-api.relaycast.dev --ci

Open observer dashboard

https://pr64-observer.relaycast.dev

@khaliqgant khaliqgant merged commit a5bd971 into main Feb 27, 2026
3 of 4 checks passed
@khaliqgant khaliqgant deleted the observer-with-api-key branch February 27, 2026 11:44
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 7 additional findings in Devin Review.

Open in Devin Review

(inbox.recentReactions?.length ?? 0) > 0;

console.debug('[piggyback] inbox fetch ok — channels=%d mentions=%d dms=%d reactions=%d',
console.error('[piggyback] inbox fetch ok — channels=%d mentions=%d dms=%d reactions=%d',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Successful inbox fetch logged at console.error instead of console.debug

The success-path log message [piggyback] inbox fetch ok was changed from console.debug to console.error. Every successful tool invocation that piggybacks inbox data will now emit an error-level log line, polluting error monitoring and alerting systems.

Root Cause

At packages/mcp/src/piggyback.ts:113, the log level was changed from console.debug to console.error for the success case:

console.error('[piggyback] inbox fetch ok — channels=%d mentions=%d dms=%d reactions=%d', ...);

This is a normal operational message ("inbox fetch ok") that should remain at debug level. The failure case on line 131 being console.error is appropriate, but the success case should not be.

Impact: Every successful MCP tool call that piggybacks inbox data will generate a spurious error log. In production, this will trigger false alerts and make it harder to find real errors in log aggregation tools.

Suggested change
console.error('[piggyback] inbox fetch ok — channels=%d mentions=%d dms=%d reactions=%d',
console.debug('[piggyback] inbox fetch ok — channels=%d mentions=%d dms=%d reactions=%d',
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant