Skip to content

Multi-workspace support spec#71

Merged
khaliqgant merged 7 commits intomainfrom
feature/multi-workspace-support
Mar 10, 2026
Merged

Multi-workspace support spec#71
khaliqgant merged 7 commits intomainfrom
feature/multi-workspace-support

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Mar 9, 2026

Adds SPEC.md with the implementation plan for multi-workspace support (Phase 1: client-side multiplexing).

Includes:

  • Top-level architecture diagrams (current vs proposed)
  • TS and Rust SDK manager abstractions
  • Exact files to modify with descriptions
  • Acceptance criteria
  • Backwards compatibility notes

See SPEC.md for full details.


Open with Devin

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread SPEC.md Outdated
Comment thread SPEC.md Outdated
Comment thread SPEC.md Outdated
Comment on lines +14 to +54
## Current single-workspace flow

### Top-level system view
```text
Agent Process -> Broker -> 1 WebSocket -> 1 Relaycast Workspace
```

### Through this repo today
```text
Inbound
-------
Relaycast Workspace
-> Relaycast Server
-> wsTransform strips/normalizes event payload
-> 1 SDK client instance (TS or Rust)
-> Broker runtime receives event with one implicit workspace
-> Agent process / local handlers

Outbound
--------
Agent process command
-> Broker runtime send call
-> 1 SDK client instance
-> Relaycast HTTP/WebSocket API
-> 1 Relaycast Workspace
```

### Current repo-internal shape
```text
TS SDK / Rust SDK
Single workspace config
-> 1 AgentClient
-> 1 WsClient
-> callbacks/events assume one implicit workspace

Server
worker.ts
-> websocket session keyed by workspaceId:agentId
wsTransform.ts
-> known websocket payloads omit workspace_id
```
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 SPEC.md violates "Keep docs concise and avoid duplicated guidance" rule

AGENTS.md mandates "Keep docs concise and avoid duplicated guidance." The SPEC.md "Current single-workspace flow" section (lines 14–54) restates architecture already documented by the source files themselves (packages/server/src/engine/wsTransform.ts, packages/sdk-typescript/src/agent.ts, etc.) and the README. This section duplicates existing guidance rather than simply referencing the source of truth files listed in AGENTS.md.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point but the SPEC.md is a one-time reference doc for the PR — it won't live in the codebase after merge. The duplication is intentional for reviewer context.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

Preview deployed!

Environment URL
API https://pr71-api.relaycast.dev
Health https://pr71-api.relaycast.dev/health
Observer https://pr71-observer.relaycast.dev/observer

This preview shares the staging database and will be cleaned up when the PR is merged or closed.

Run E2E tests

npm run e2e -- https://pr71-api.relaycast.dev --ci

Open observer dashboard

https://pr71-observer.relaycast.dev/observer

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@khaliqgant khaliqgant merged commit 8b0556e into main Mar 10, 2026
4 checks passed
@khaliqgant khaliqgant deleted the feature/multi-workspace-support branch March 10, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant