fix: make text optional in local daemon Group DM endpoint#72
Merged
khaliqgant merged 8 commits intomainfrom Mar 10, 2026
Merged
fix: make text optional in local daemon Group DM endpoint#72khaliqgant merged 8 commits intomainfrom
khaliqgant merged 8 commits intomainfrom
Conversation
…server
The SDK's createGroup() sends {participants, name} without a text field,
then sends the initial message separately via sendMessage(). The local
daemon required text as mandatory, causing serde deserialization to fail
with "Malformed JSON in request body".
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Preview deployed!
This preview shares the staging database and will be cleaned up when the PR is merged or closed. Run E2E testsnpm run e2e -- https://pr72-api.relaycast.dev --ciOpen observer dashboard |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local daemon's Group DM endpoint required
textas a mandatory field, but the production server and SDK treat it as optional. The SDK callscreateGroup({ participants, name })without text, thensendMessage()separately.Fix: Changed
text: String→text: Option<String>inCreateGroupDmRequestand made initial message posting conditional.Verification: All 59 e2e tests pass (0 failures), including the 3 Group DM tests that were previously failing.