feat(ts-sdk): add workspace lookup and ensure helpers#98
Merged
Conversation
Author
|
Preview deployed!
This preview shares the staging database and will be cleaned up when the PR is merged or closed. Run E2E testsnpm run e2e -- https://pr98-api.relaycast.dev --ciOpen observer dashboard |
willwashburn
requested changes
Mar 19, 2026
| } | ||
|
|
||
| const data = (parsed as { data: unknown }).data; | ||
| return camelizeKeys(WorkspaceLookupSchema.parse(data)); |
Member
There was a problem hiding this comment.
why can't we just use the schema.parse instead of all the manual shape checking use on lines 172-208? there has to be a more elegant way
Author
There was a problem hiding this comment.
Swapped the manual envelope/data shape checks over to ApiResponseSchema(WorkspaceLookupSchema).safeParse(...) and used the parsed discriminated union to handle success vs error. I also applied the same cleanup to createWorkspace for consistency since it had the same open-coded response parsing pattern. Behavior stays the same, including returning null on 404 from lookupWorkspace.
willwashburn
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RelayCast.lookupWorkspace()andRelayCast.ensureWorkspace()helperscc @willwashburn