Skip to content

Split SDK CLI utilities into explicit subpaths#172

Merged
khaliqgant merged 1 commit into
mainfrom
codex/issue-170-worker-safe-sdk
May 20, 2026
Merged

Split SDK CLI utilities into explicit subpaths#172
khaliqgant merged 1 commit into
mainfrom
codex/issue-170-worker-safe-sdk

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

Summary

  • keep the default @relayfile/sdk entry Worker-safe by removing static imports/exports of CLI-only mount and login modules
  • add explicit @relayfile/sdk/cli, @relayfile/sdk/mount-launcher, and @relayfile/sdk/cloud-login package exports
  • split Worker-safe cloud token refresh into its own module and add an import-graph regression test
  • update SDK docs/examples that use interactive login or the default mount launcher to import from @relayfile/sdk/cli

Closes #170.

Self-review notes

  • Reviewed the default entry graph after the first pass and tightened @relayfile/sdk/cli so it re-exports the main SDK surface plus CLI-specific overrides.
  • Left unrelated local changes out of the commit (package-lock.json, .trajectories/index.json, and docs/canonical-identity-spec.md).

Verification

  • npm run typecheck --workspace=packages/sdk/typescript
  • npm run build --workspace=packages/sdk/typescript
  • npm run test --workspace=packages/sdk/typescript
  • npm pack --workspace=packages/sdk/typescript --dry-run --json
  • Browser-platform esbuild smoke test importing @relayfile/sdk; bundle/metafile contained no node:child_process, node:http, node:fs, node:path, node:process, node:url, mount-launcher, or cloud-login
  • Node import smoke test for @relayfile/sdk, @relayfile/sdk/cli, and @relayfile/sdk/mount-launcher

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Warning

Rate limit exceeded

@khaliqgant has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 50 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f610fe89-5676-4699-b0f7-793fd6648dee

📥 Commits

Reviewing files that changed from the base of the PR and between 76f9b7a and 90704c6.

📒 Files selected for processing (14)
  • docs/agent-workspace-golden-path.md
  • docs/guides/post-auth-mount-session.md
  • packages/sdk/typescript/README.md
  • packages/sdk/typescript/package.json
  • packages/sdk/typescript/src/cli/index.ts
  • packages/sdk/typescript/src/cli/setup.ts
  • packages/sdk/typescript/src/cloud-login.ts
  • packages/sdk/typescript/src/cloud-token-provider.ts
  • packages/sdk/typescript/src/import-safety.test.ts
  • packages/sdk/typescript/src/index.ts
  • packages/sdk/typescript/src/mount-launcher.ts
  • packages/sdk/typescript/src/setup-types.ts
  • packages/sdk/typescript/src/setup.test.ts
  • packages/sdk/typescript/src/setup.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-170-worker-safe-sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Relayfile Eval Review

Run: .relayfile/evals/runs/2026-05-20T20-15-41-713Z-HEAD-provider
Mode: provider
Git SHA: 7fe7df4

Passed: 4 | Needs human: 0 | Reviewable: 0 | Missing output: 0 | Failed: 0 | Skipped: 0

Human Review Cases

No reviewable human-review cases captured Relayfile output.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

@khaliqgant khaliqgant merged commit f10fb62 into main May 20, 2026
10 checks passed
@khaliqgant khaliqgant deleted the codex/issue-170-worker-safe-sdk branch May 20, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@relayfile/sdk: split CLI utilities (mount-launcher, cloud-login) into subpath export so they tree-shake out of Worker bundles

1 participant