Skip to content

fix: guard mount writebacks from remote drift#184

Merged
khaliqgant merged 2 commits into
mainfrom
codex/issue-182-writeback-guard-main
May 21, 2026
Merged

fix: guard mount writebacks from remote drift#184
khaliqgant merged 2 commits into
mainfrom
codex/issue-182-writeback-guard-main

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

Summary

  • chunk mount bulk writeback batches by serialized request size before calling /fs/bulk
  • require explicit dirty/delete-pending state for tracked local writebacks instead of treating hash drift as local intent
  • let authoritative remote pulls overwrite unmarked local drift and add regression coverage for drift, deletes, chunking, and pending status

Closes #182

Tests

  • go test ./cmd/relayfile-cli ./cmd/relayfile-mount ./internal/mountsync/... -count=1 -timeout 240s

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@khaliqgant has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 45 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d3396503-b429-4335-bf51-359f87428326

📥 Commits

Reviewing files that changed from the base of the PR and between a9b7153 and 96ab0ab.

📒 Files selected for processing (3)
  • internal/mountsync/mount_root_clobber_test.go
  • internal/mountsync/syncer.go
  • internal/mountsync/syncer_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-182-writeback-guard-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Relayfile Eval Review

Run: .relayfile/evals/runs/2026-05-21T12-37-59-480Z-HEAD-provider
Mode: provider
Git SHA: 7a86eb3

Passed: 4 | Needs human: 0 | Reviewable: 0 | Missing output: 0 | Failed: 0 | Skipped: 0

Human Review Cases

No reviewable human-review cases captured Relayfile output.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 6 additional findings in Devin Review.

Open in Devin Review

Comment thread internal/mountsync/syncer.go Outdated
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@khaliqgant khaliqgant merged commit ce519cc into main May 21, 2026
9 checks passed
@khaliqgant khaliqgant deleted the codex/issue-182-writeback-guard-main branch May 21, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mount: writeback batch unbounded + reconciler pushes freshly-pulled files (413 loop)

1 participant