-
Notifications
You must be signed in to change notification settings - Fork 0
Swap chokidar for @parcel/watcher in local-mount #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ff2935f
Swap chokidar for @parcel/watcher in local-mount
willwashburn b2e90df
Rename writeFinishMs option to debounceMs
willwashburn 6810e61
Merge branch 'main' into parcel/watcher
willwashburn 6a1457c
Update package-lock.json
willwashburn 94513de
Add per-package CHANGELOGs and README note
willwashburn f291a17
Finalize per-package CHANGELOGs on release
willwashburn 9195511
Prevent subscription leak on subscribe failure
willwashburn 62e5ba6
Make AutoSync.stop quiesce pending debounces
willwashburn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "id": "traj_iuzm83ogm43k", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Replace chokidar with @parcel/watcher in local-mount" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-04-20T20:35:15.759Z", | ||
| "completedAt": "2026-04-20T20:58:15.412Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-04-20T20:58:15.094Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_2g7q1zwb1j1e", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-04-20T20:58:15.094Z", | ||
| "endedAt": "2026-04-20T20:58:15.412Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1776718695095, | ||
| "type": "decision", | ||
| "content": "Switched watcher from chokidar v4 to @parcel/watcher 2.5.6: Switched watcher from chokidar v4 to @parcel/watcher 2.5.6", | ||
| "raw": { | ||
| "question": "Switched watcher from chokidar v4 to @parcel/watcher 2.5.6", | ||
| "chosen": "Switched watcher from chokidar v4 to @parcel/watcher 2.5.6", | ||
| "alternatives": [], | ||
| "reasoning": "Chokidar v4's awaitWriteFinish polling + fs.watch teardown caused noticeable hangs on exit. @parcel/watcher uses native FSEvents/inotify/ReadDirectoryChangesW with clean async unsubscribe. Replaced awaitWriteFinish with a small per-path setTimeout debounce; reconcile loop + mtime/content check absorb the looser write semantics." | ||
| }, | ||
| "significance": "high" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Replaced chokidar with @parcel/watcher in packages/local-mount. All 22 tests pass. Exit-hang should be gone because unsubscribe() on native-backed watchers resolves promptly instead of draining stability-poll timers.", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.85 | ||
| }, | ||
| "commits": [], | ||
| "filesChanged": [], | ||
| "projectId": "/Users/will/Projects/relayfile", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "81a329d005404a6f156c837829d5c5d8d47aa05d", | ||
| "endRef": "81a329d005404a6f156c837829d5c5d8d47aa05d" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Trajectory: Replace chokidar with @parcel/watcher in local-mount | ||
|
|
||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 85% | ||
| > **Started:** April 20, 2026 at 04:35 PM | ||
| > **Completed:** April 20, 2026 at 04:58 PM | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| Replaced chokidar with @parcel/watcher in packages/local-mount. All 22 tests pass. Exit-hang should be gone because unsubscribe() on native-backed watchers resolves promptly instead of draining stability-poll timers. | ||
|
|
||
| **Approach:** Standard approach | ||
|
|
||
| --- | ||
|
|
||
| ## Key Decisions | ||
|
|
||
| ### Switched watcher from chokidar v4 to @parcel/watcher 2.5.6 | ||
| - **Chose:** Switched watcher from chokidar v4 to @parcel/watcher 2.5.6 | ||
| - **Reasoning:** Chokidar v4's awaitWriteFinish polling + fs.watch teardown caused noticeable hangs on exit. @parcel/watcher uses native FSEvents/inotify/ReadDirectoryChangesW with clean async unsubscribe. Replaced awaitWriteFinish with a small per-path setTimeout debounce; reconcile loop + mtime/content check absorb the looser write semantics. | ||
|
|
||
| --- | ||
|
|
||
| ## Chapters | ||
|
|
||
| ### 1. Work | ||
| *Agent: default* | ||
|
|
||
| - Switched watcher from chokidar v4 to @parcel/watcher 2.5.6: Switched watcher from chokidar v4 to @parcel/watcher 2.5.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projectIdcontains an absolute local path (/Users/...), which is machine-specific and can leak developer information in published history. Consider using a repo identifier (e.g. name/URL) or a relative path, or removing this field from committed artifacts.